Unable to send e-mail. Please contact the site admin, if the problem persists.

A lot more has to be changed, things like variable changing too. Ie, the mail I get looks liket his:

'You have been added as a Y for by"

I'll provide a patch as soon as I can!

Hi,

Attached patch fixes the mail issues. I also changed a few other small things:
- Space typo in settings page in subject.
- Added %recipient to the body of the mail.
- changed $inserts array - no matter what I tried, I always got the mail that I was added as an editor. Difference between editors & viewers is now also ok in the mail.

Happy testing!

Ok, there is an error in the first patch, it doesn't save editors anymore.
This one fixes it. One error still though, the role in the mail is always editor no matter if you add editors or viewers. Going to look at it later.

Ok, This one also fixes the role in the mail.
Happy testing :)

This patch haven't been applied to the latest version?

Because my sent mail looks like:

Date: Mon, 19 Jan 2009 01:05:32 GMT
Message-Id: <200901190105.n0J15W1V001300@web245.extendcp.co.uk>
To: "<p>You have been added as a editor  for some content by admin"</p>
Subject:  

@abamarus. Please don't mark an issue as fixed when a patch is still under review/yet to be committed (unless you are the modules maintainer / co-maintainer). Perhaps you were trying to mark it RTBC and accidently chose fixed? For more information on the patch review process see http://drupal.org/patch/review .

Patches usually need a positive review by at least two people other than the original author before being set to RTBC. In the normal course of development, patches will go through several iterations, often with changes by multiple authors before making their way into core. Although this process isn't foolproof, it guarantees that nearly all code committed to core has been peer reviewed by a number of people, has been refined for performance, readability, usability, and will not introduce regressions or new bugs into the system.

I hope this helps...I am sure the maintainer will address the issue when he has time.

Looks like the patch fixed the email but seems as though a few simple bugs remain. We (dougvann http://drupal.org/user/222746 and I) tested the settings:

we created content-->a new blog entry
--we clicked the checkbox for 'Private'
--we added an editor
--we added a viewer

None of these settings remained when we went back to edit the blog entry.

--The 'Private' checkbox was not checked (which means saving now would make the page public)
--the editor does not show up (the user did not show up when we added this user to both editor and viewer | on a separate test, the user did show up when we just added the user to editor and NOT to viewer)
--the viewer does not show up

--We tested the node (blog entry) to see if it actually was private, and it is.
--We tested the editor to see if they could edit the node and they can.
--We tested the viewer to see if they could view the node and they can.

The module appears to be saving everything to the database, but does not always display the database info in the user interface when the admin comes back to edit the node.

Hope this helps.

@bradelygsmith have you tried the patches that have been posted in the issue queue addressing these problems -
#361507: Private doesnt remain checked
#360651: Shared posts tab not showing on user account
#360460: rebuilding permissions makes private coherent_access nodes public

I think you will find that applying these patches will help. Hopefully the maintainer will have a chance to look at them soon so a working release can be made.

Thanks

Did any of the aforementioned patches ever get committed? Just wondering as I'm seeing this issue having just migrated sites (and yes, the SMTP server is working...)

warning: mail() [function.mail]: SMTP server response: 550 5.1.1 <You have been added as a editor for A New Node by snorkers>... User unknown in DRUPAL_ROOT\includes\mail.inc on line 193.

And I hadn't added a single thing in the Shared Editing section... so is that the problem - is a blank entry translated as 'User Unknown'?

Just wondering if this was ever really addressed, before I start chasing a whole host of potential other modules that could be conflicting (potential culprits may also include OG User Roles, Realname....). Seems to have no work on DEV since Feb 09, and none of the DEV changes have been rolled into a formal release.

Not a blank entry issue. Just added a valid editor and same message still appears.

@snorkers. No, the patch in #6 never got past 'needs work' after the review by bradleygsmith .

If you are up for it, you might try applying the patch in #6 to the latest dev (may need to do this manually, or ask swentel for a reroll), and see if you encounter the same problems as bradleygsmith did. Now that the patches listed in #15 have been committed, the patch in #6 might pass review.

OK - finally got a chance to look at this.

Rolled the patch #6 against DEV, which succeded:

Hunk #1 succeeded at 151 (offset 6 lines).
Hunk #2 succeeded at 510 (offset 15 lines).
Hunk #3 succeeded at 706 (offset 29 lines).

I've tested it a few times switching between 1.0 and the patched DEV:

In 6.x-1.0 I still get the error message for every node I create (as described ay #16); with the patched DEV the error does not appear. The patched DEV also appears to function correctly, sending an email to nominated 'shared' editors.

So I'll run with the patched DEV version for a while and see if any anomalies crop up. I have to go live this month, but this version seems more reliable than 1.0. *gulp*

Could I ask the rest of the community to review this code too (changed issue status, as 'Needs review' gets a little more attention - my apologies if I've broken any d.o protocol). It would be great if a new DEV could be re-rolled (I've attached a ZIP archive for those who are afraid of patching)... but it would also be great if a new release could be made for this very handy module before we are into the frenzy of migration to D7.

Sorry - forgot to mention bradleygsmith's issues (#14-15)... The checkbox stays checked (if selected). Editors/Viewers seemed pretty solid too, although one slight glitch when I hit 'Add Editor' before the autocomplete JS had caught up. The only user name that doesn't remain is User 1... which seems entirely logical anyway.

So as an update it looks pretty good to me. Anyone else?

I've been using this tweak to the module and it's largely working... because Coherent Access wasn't working well without this patch to DEV, I hadn't really picked up any errors... so now I am getting 2 problems which may well be fresh issues, or could be related to the patch #325572-6: Unable to send e-mail. Please contact the site admin, if the problem persists.. If anyone else following this issue has spotted the following, please post here, otherwise I'll raise fresh issues against DEV:

1. When I create node, I get an email back to myself, saying that I'm a shared editor... even though I didn't add myself (or anyone else) to the shared editors list. Whilst it's kind of *nice* to get, I think it could become annoying, and is not the desired functionality of this module.
2. All 'shared editor' emails are from [logged in userid]@proofpoint2 (eg, snorkers@proofpoint2). I think Proofpoint is some sort of email security package that must be used by my university's SMTP relay... but why do all my other site emails come from the correct site email 'from' address and ones from Coherent Access have something else. It suggests that the Coherent Access emails may have the 'from' address incorrectly formatted and being passed out as userid rather than site address (assuming that the mail relay then adds '@proofpoint2' because it attempts to correct the format of the 'from' address). Other people may not be so lucky, so coherent access emails could well end up being filtered out or blacklisted if they are not formatted correctly.

I tested this patch and can confirm that it provides a fix to this bug. I have re-rolled the patch (against DRUPAL-6--1) to fix the issue described by @snorkers in #21, regarding the emails from name@hostname. Emails now appear to come from the node owner's email (or editor's email that assigns permission if editors are trusted). I was not able to reproduce the issue raised by @snorkers in #21 regarding getting a mail sent two emails; one to the "shared editing changer" and one to the added recipient.

As a side note I noticed a few things that may be new issues or just FYIs:
*) The grammar in the subject and body will be incorrect if the added role is editor vs viewer. ie "You have been added as a editor" vs "You have been added as a viewer" in the first example should be "You have been added as an editor"

*) If a user is already a viewer and they are added as an editor, no new message about their change of permission is sent. This is also the case if their permission is revoked. Is by design?

*) A relatively larger than necessary data structure is passed through drupal_mail() for the third argument (optional parameters for message substitution). This is totally clean and may be a good point for refactoring where in coherent_access_mail we can just apply the substitutions with t().

*) The variables available for substitution are not documented anywhere. I think maybe this should be added as a description in the admin/settings/coherent-access forms.

Re-rolling because I found another bug related to this issue that prevents users from getting an email reporting the correct role they had been assigned.

Thanks for the re-roll... does the patch at #24 also include the code addressed at #6 (32571_1.patch) ... just wondering whether to roll the patch #24 against the current coherent_access release (6.x-1.0 or 6.x-1.x-dev?), as the patch is rejected if rolled against 1.0 with patch 32571_1 applied apriori. A few of my modules are in configuration hell with applied patches - and this module's releases have not been touched now for over 8 months.

@snorkers, thanks for raising the questions in #25. Yes #24 includes the logic from #6, and I should have mentioned it, but this patch was made against a clean version of 6.x-1.x-dev.

Finally got a chance to implement the patch against a clean DEV download - works just fine.

As soon as this patch gets committed to a new release [and configuration stabilizes] I'll investigate and raise the issue separately of 'You have been added as a viewer for [new node] by [user]' email that is sent bu default to the person creating a new node. Still not sure if it's just a 'me' or a more widespread issue.

Thanks so much @evoltech for working on this.

This issue has been marked RTBC for about 20 weeks now. It would help to know if this is going to committed, or if some further action is needed. Thanks.

Thanks for all the work everyone, sorry for the long delay in getting this commited.