Archive feature is broken

Grinch2171 - October 29, 2008 - 16:57
Project:Chat Room
Version:6.x-1.0-beta2
Component:Code
Category:bug report
Priority:critical
Assigned:justinrandell
Status:closed
Description

I downloaded the beta and created my chatroom however when I try and access it I get the following error

Fatal error: Call to undefined function chatroom_chat_get_latest_msgs() in /home3/sites/all/modules/chatroom/chatroom.module on line 636

Any suggestions?

#1

opensanta - October 29, 2008 - 17:04

I think the archiving feature is causing that error. Try turning it off.

Patches welcomed.

#2

opensanta - October 29, 2008 - 17:42
Version:6.x-1.1-beta1» 6.x-1.0-beta2

updating version

#3

Grinch2171 - October 30, 2008 - 12:42

Turning off the archive worked but before I turned it off I upgraded to the beta2 version and still got that error.

#4

Babalu - October 31, 2008 - 11:33

subscribing

#5

netgenius - November 9, 2008 - 20:47

Yes, still happens in beta2, turning off "auto-archive" does seem to make the error go away.

#6

vallab444 - November 24, 2008 - 11:54

it worked after I turned off archiving. thanks. unobtrusive UI, I liked it.

#7

opensanta - December 3, 2008 - 22:26
Title:Fatal error: Call to undefined function chatroom_chat_get_latest_msgs» Archive feature is broken
Category:support request» bug report

#8

rsvelko - December 15, 2008 - 17:48
Priority:normal» critical

guys - there isn't any function

chatroom_chat_get_latest_msgs

anywhere in the files of this module - no wonder php gives that error.... The archiving probably works but in its begining it calls that undef func ...

the string

function chatroom_chat_get_latest_msgs

can be found here in the module's files: (recursive find done with notepad++)

[chatroom\chatroom.module]
Line 636 : $msgs = chatroom_chat_get_latest_msgs($chat_id, $user->uid);
[chatroom\updates.inc]
Line 35 : $js->msgs = chatroom_chat_get_latest_msgs($chat_id, $user->uid, $last_msg_id, $timezone, $smileys);
Line 91 : $js->msgs = chatroom_chat_get_latest_msgs($chat_id, $user->uid, $last_msg_id, $timezone, $smileys);

EDIT: @maintainer: please comment that 636th line or do sth fast - switched the issue to critical

#9

britne - January 17, 2009 - 22:41

subscribing

#10

Paul Kishimoto - March 27, 2009 - 18:12

I just commented on duplicate #362728: Fatal error: Call to undefined function chatroom_chat_get_latest_msgs():

The calls to chatroom_chat_get_latest_msgs need to be updated with calls to chatroom_load_messages (chatroom.module, l.819), which is newer code that accomplishes the same thing.

@rsvelko: unfortunately it is not true that "archiving probably works"; beyond the calls to that removed function, there are also several table references to {chatroom_msg_archive}, which has been removed in favour of an 'archived' column in {chatroom_msg}. Those queries also need to be updated.

#11

vallab444 - May 7, 2009 - 11:06
Status:active» closed

#12

justinrandell - September 12, 2009 - 14:01
Assigned to:Anonymous» justinrandell
Status:closed» active

ouch. another case of performance killing changes to the chatroom code. i'll work on using the archived flags to get something out, then restore the archive table later.

#13

justinrandell - September 12, 2009 - 14:29
Status:active» needs review

i've committed code to the DRUPAL-6--1 branch to fix this.

please update and see if it work for you.

#14

justinrandell - October 20, 2009 - 10:53
Status:needs review» fixed

#15

System Message - November 3, 2009 - 11:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.