After my last security update of Drupal 5 and doing something like image rotation in the "Album Contents" section
the Gallery produce many errors after submit like:

# warning: Missing argument 2 for node_form_validate() in /usr/share/drupal5/modules/node/node.module on line 2053.
# warning: Missing argument 3 for node_form_validate() in /usr/share/drupal5/modules/node/node.module on line 2053.
# Der Pfad wird bereits verwendet.
# warning: Missing argument 2 for node_form_validate() in /usr/share/drupal5/modules/node/node.module on line 2053.

nothing was done after submit. Also changing image titles aren't working.
The Gallery is unusable in the Contents section.

Comments

eddified’s picture

eddified commented

I have this same problem. I haven't tried rotating the images in the "album contents" view, but what I have tried (deleting images) does still work, despite the error messages.

The easiest way to duplicate this is actually to not make ANY changes, but just to hit "Submit" anyway. You'll see the error messages, even if you didn't make any changes.

--------------------------------

About the other error message you are getting: "Der Pfad wird bereits verwendet." (which isn't directly connected with acidfree, I don't think -- or is it? not sure)--- I'm getting it as well. Except in English, it's something like "The path is already in use."

If you use the 'pathauto' module (or maybe even if you don't--not sure) and if you don't fix this second problem, then when you do "mass import" of a video, the thumbnail image node won't get created for the video, and you'll never see a thumbnail on it (it won't even be re-generated later). Here's a work around: This problem is caused by an incorrect entry in the url_alias table.

  1. Goto "admin/settings/acidfree" and under the "Fields to show" section, change the "URL path settings" select to "not shown".
    • I'm not sure if you need to also uncheck 'Show all fields available in "Album Contents" view', but I would recommend unchecking it (opening the 'all fields' fieldset never works for me anyway because of a js error).

    Doing this will prevent the incorrect entry from being inserted again in the url_alias table.

  2. Now we just need to delete the row in the url_alias table where the `dst` column is equal to the empty string (''). There should never be rows in the url_alias table with `dst` column set to the empty string, as far as I can tell.
vhmauery’s picture

vhmauery commented
Status: Active » Fixed

I saw this in my installation and was not sure if I was the only one... Glad you posted the bug. I tracked it down to changes in node.module and committed a fix.

eddified’s picture

eddified commented

I'm glad you figured it out. I spent hours trying to figure out this bug and came up with nothing. I'll need to hear how you managed to fix it sometime. I don't really know how forms work in drupal, and I couldn't figure it out because I had no clue how the form was supposed to look. Apparently the form gave the Node module some tizzy fits... at least that's what I got out of my hours of poking around in the code.

vhmauery’s picture

vhmauery commented

To find the source of the problem, I downloaded drupal 5 versions 7 through 12. My logic was this: album contents worked fine with d5.7, but an upgrade to d5.12 broke it. I took diffs between each of the versions and applied diffs to bisect versions until I tracked down which version had the changes that broke album contents. Then I looked at this diff for any changes that were form related. I backed this change out and viola! The comments in the change were sufficient to tell me how to fix it.

eddified’s picture

eddified commented

Very interesting. Good work.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.