in the transaction search screen, link "shipping notify" does not work. generated link is "admin/store/shipping/send" (lines #1282 & #1289), and this is not defined in the current shipping module.

this can be fixed by changing the link to "admin/store/settings/shipping" and modifying shipping module to get the correct param for txnid (line #77 arg(4) -> arg(5)), or by defining the admin/store/shipping link in shipping.module, but there might be some reason why it was removed, so i would go for the first fix.

let me know which patch to post :)

CommentFileSizeAuthor
#2 ec-shipnotif-fix_0.patch2.12 KBsyllance

Comments

matt westgate’s picture

matt westgate commented

I agree. Let's go with fix #1.

syllance’s picture

syllance commented
StatusFileSize
new ec-shipnotif-fix_0.patch2.12 KB

and here is the patch for fix #1 :)

it change the link in store.module, and change the arg position in shipping.module.

syllance’s picture

syllance commented
Assigned: Unassigned » syllance
Status: Active » Needs review
ñull’s picture

ñull commented
Title: shipping notify link not working » shipping notify link working incorrectly
Status: Needs review » Active

In present CVS the shipping notify link is working with or without your patch, but I noticed the following:

    • The date in the shipping notify preview is always received Thu, 01/01/1970 - 02:00. while elsewhere it gives the correct date
      The ordered items are not listed.

    • For this reason I felt free to change subject and status.

    I tried to figure out what the problem is but I am missing debug tools to check variables.

    sime’s picture

    sime
    any/any
    Location Melbourne
    commented
    Component: shipping » ec_mail

    moving all notification issues under ec_mail. There are a lot and should be checked together.

    brmassa’s picture

    brmassa commented
    Status: Active » Fixed

    duplicated on http://drupal.org/node/162512

    Anonymous’s picture

    (not verified) commented
    Status: Fixed » Closed (fixed)