At this point, I think dropping the bootstrap flag from system table would just work as the bootstrap invoker calls module_implements which is registry based and loads on demand. I would suspect that calling module_invoke_all would work as well, we can drop bootstrap_invoke_all as well. module_list can lose its $bootstrap flag as well as there is no sensible notion of that any more. Once that's done the function will return the list of enabled modules so let's rename it to that. We can have a module_list_loaded which just is a wrapper around drupal_load.... 'cos you know registry_check_code really should use drupal_load. if this awfully resembles the total module revamp, well, we are getting there :)

CommentFileSizeAuthor
#3 bootstrap.begone.patch13.85 KBAnonymous (not verified)
#2 bootstrap.begone.patch13.1 KBAnonymous (not verified)

Comments

Anonymous’s picture

Assigned: Unassigned »

i'll take this one on.

Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new13.1 KB

here's a first cut.

Anonymous’s picture

StatusFileSize
new13.85 KB

and, here's a second go.

updated to keep up with HEAD, and based on some feedback from chx in #drupal - i'd missed a chunk to be removed from module_rebuild_cache.

Anonymous’s picture

Status: Needs review » Needs work

from #drupal:

(15:46:44) webchick: beejeebus: just FYI, for http://drupal.org/node/333143 to get committed we'll need to have tests that prove that hook_boot() and hook_exit() continue to work as planned.

so, setting to CNW.

Anonymous’s picture

Status: Needs work » Needs review

hmm, seems we already test that hook_boot and hook_exit get called as they should in HookBootExitTestCase.

setting back to code needs review, patch updated only to keep up with HEAD, all tests pass.

dries’s picture

Status: Needs review » Fixed

This looks sane. Nice clean-up. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.