pift doesn't handle editing of filenames/addition of files on comment edit
grendzy - November 13, 2008 - 17:03
| Project: | Project issue file testing |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Description
On issue #330633: Temporary file cleanup needs some love (UnitTest included!), the wrong patch got tested. #1 was tested, even though #4 was the latest.
(Sorry if this isn't the right place for support requests regarding the drupal.org test bot).
#1
all files in an issue are supposed to be tested. most likely the more recent files haven't been processed by the testing platform yet. please be patient, as far as i can tell everything is working as it's supposed to.
#2
It seems to me that if there are untested patches, then the bot has no reason to flag it as "needs work". Especially as I've seen patches wait for over a week when the bot's queue is backlogged. The handbook indicates that CNR is the correct status when a patch has been created and needs review and testing.
At the very least, the comment is inaccurate:
The last submitted patch failed testing. would more accurately read The last tested patch failed testing.
#3
no, the comment is accurate. the framework will only CNW an issue if the last submitted patch failed testing. if a previously patch failed, and there are new patches in the issue that are untested at the time that patch is failed, then the issue will _not_ be CNW'd.
if it is, then this is a bug, and somebody would need to show me some cases where this is happening so that i can fix it.
until then, this is working as expected.
#4
Here are a couple examples:
#5
all of these examples except one are from the time HEAD itself was broken, and the framework was reporting false results. those patches were probably retested manually, and then later got a different result back.
http://drupal.org/node/278770 is the only recent one i see in the list. the patch in that issue was never entered into the testing queue in the first place. did you happen to edit that comment and either attach the file afterwards or edit the filename? the framework doesn't currently support that, and we're trying to decide if we should just block editing of attachments entirely, or add support.
#6
Thanks for looking into it. Yes, I did attach the file after submitting the comment.
Regarding blocking of editing attachments, that's an interesting question. Maybe a solution could be blocking deletion / changing of existing attachments, but allowing new ones to be added. How are multiple files currently handled?
I'll attach a mockup of what this might look like.
#7
multiple attachments are fine -- the problem is either adding a new attachment on edit, or editing a patch name on edit. a patch that addresses these shortcomings is welcome. :)
for now, i've temporarily patched drupal.org to disable editing of attachments on issue followups -- i think this is a livable short-term solution until we have a better long-term one.
#8
Editing of files will remain off, thus this is not a concern. http://drupal.org/node/407802#comment-1378810