Hi,

Nice to see a useful module as a fee module become official for UberTuber. It is an excellent idea to have a module that allow to add custom line items without the need to create a new contribution each time you need one.

I think the next step to greatly improve his extensibility would be an integration with conditional actions. Like that, you could add some conditions to add fee or not.

Great job for your module !

Comments

mrfelton’s picture

mrfelton commented
Assigned: Unassigned » mrfelton

I made some good inroads on this last night (code not available yet). But now I want to take a step back and really think about the best way of implementing this - I'm hoping for suggestions here...

The way I see it, you need to be able to:

  1. Create a global Fee entity, with a default price
  2. Override the fee price at the product/product class level
  3. Conditionally apply this fee to orders
  4. Exclude individual products from conditional application of the fee
  5. Specify an order of precedence for fee application

With regard to conditionally applying fees, I think the fee module itself needs to provide some conditions, to allow you to check:

  • The presence a fee
  • The total price of a fee
  • The amount of times a fee has been applied

Am I missing anything?

zmove’s picture

zmove commented

Yeah, quite good ideas. However, I would like to suggest some conditions :

  • Based on user informations (role, profile, or any $user object information)
  • Custom PHP code

I know this is more general rules than the ones your module provide, it should be surely provided by the core CA system, but maybe working on it and submitting patch for the core would definitely add these essential features

mrfelton’s picture

mrfelton commented
Status: Active » Closed (won't fix)

I'm closing this as I'm pretty sure these have been added into Ubercart core now.