DatabaseSchema_pgsql::addField() calls $this->_createFieldSql() while that function is in fact called $this->createFieldSql().

CommentFileSizeAuthor
#8 338586-add-field-undefined-function.patch1.18 KBdamien tournoud
#5 338586-add-field-undefined-function.patch3.1 KBswentel
#3 338586-add-field-undefined-function.patch894 bytesdamien tournoud
#1 338586-add-field-undefined-function.patch895 bytesdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 338586-add-field-undefined-function.patch895 bytes
swentel’s picture

swentel commented

Seems like there's another one: Call to undefined method DatabaseSchema_pgsql::_processField()

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 338586-add-field-undefined-function.patch894 bytes
swentel’s picture

swentel commented

All succeed except 7 fails on schema api
Insert with a default succeeded. Other schema.test 50 SchemaTestCase->testSchema()
Insert into the new table succeeded. Other schema.test 62 SchemaTestCase->testSchema()
Two fields were successfully inserted. Other schema.test 66 SchemaTestCase->testSchema()
Insert with a serial succeeded. Other schema.test 80 SchemaTestCase->testSchema()
Insert with a serial succeeded. Other schema.test 82 SchemaTestCase->testSchema()
The serial is monotone. Other schema.test 84 SchemaTestCase->testSchema()
There were two rows. Other schema.test 87 SchemaTestCase->testSchema()

swentel’s picture

swentel commented
StatusFileSize
new 338586-add-field-undefined-function.patch3.1 KB

Ok, patch contains 3 other very small fixes in schema.test which makes all database tests pass,
HOWEVER, someone with more postgres skills should find out why those small fixes make them pass and why a default value of 0 makes it fail ..

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work

Well, no, you will not modify the test case to satisfy the PostgreSQL driver!

swentel’s picture

swentel commented

I know, I should have marked it CNW also, just wanted to point out with the patch where the failures were :)

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 338586-add-field-undefined-function.patch1.18 KB

This should be better.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Last patch makes all Databases tests pass, so marking rtbc

grub3’s picture

grub3 commented

Yes it works like a charm.

grub3’s picture

grub3 commented

What is the impact of this bug on database creation under PostgreSQL?
Should I delete the Drupal7 database and create a new one from scratch?

dries’s picture

dries commented

Committed to CVS HEAD. Thanks! :)

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Fixed
serenecloud’s picture

serenecloud commented

Agreed with the above. After applying http://drupal.org/node/337794 and this patch I am able to run all simpletests on php5, apache2, postgres 8.1 without this error:

Call to undefined method DatabaseSchema_pgsql::_createFieldSql()

Final Simpletest output:

Testing
The tests have finished running.
6689 passes, 146 fails, and 47 exceptions

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.