Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
DatabaseSchema_pgsql::addField()
calls $this->_createFieldSql()
while that function is in fact called $this->createFieldSql()
.
Comment | File | Size | Author |
---|---|---|---|
#8 | 338586-add-field-undefined-function.patch | 1.18 KB | Damien Tournoud |
#5 | 338586-add-field-undefined-function.patch | 3.1 KB | swentel |
#3 | 338586-add-field-undefined-function.patch | 894 bytes | Damien Tournoud |
#1 | 338586-add-field-undefined-function.patch | 895 bytes | Damien Tournoud |
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedComment #2
swentel CreditAttribution: swentel commentedSeems like there's another one: Call to undefined method DatabaseSchema_pgsql::_processField()
Comment #3
Damien Tournoud CreditAttribution: Damien Tournoud commentedComment #4
swentel CreditAttribution: swentel commentedAll succeed except 7 fails on schema api
Insert with a default succeeded. Other schema.test 50 SchemaTestCase->testSchema()
Insert into the new table succeeded. Other schema.test 62 SchemaTestCase->testSchema()
Two fields were successfully inserted. Other schema.test 66 SchemaTestCase->testSchema()
Insert with a serial succeeded. Other schema.test 80 SchemaTestCase->testSchema()
Insert with a serial succeeded. Other schema.test 82 SchemaTestCase->testSchema()
The serial is monotone. Other schema.test 84 SchemaTestCase->testSchema()
There were two rows. Other schema.test 87 SchemaTestCase->testSchema()
Comment #5
swentel CreditAttribution: swentel commentedOk, patch contains 3 other very small fixes in schema.test which makes all database tests pass,
HOWEVER, someone with more postgres skills should find out why those small fixes make them pass and why a default value of 0 makes it fail ..
Comment #6
Damien Tournoud CreditAttribution: Damien Tournoud commentedWell, no, you will not modify the test case to satisfy the PostgreSQL driver!
Comment #7
swentel CreditAttribution: swentel commentedI know, I should have marked it CNW also, just wanted to point out with the patch where the failures were :)
Comment #8
Damien Tournoud CreditAttribution: Damien Tournoud commentedThis should be better.
Comment #9
swentel CreditAttribution: swentel commentedLast patch makes all Databases tests pass, so marking rtbc
Comment #10
grub3 CreditAttribution: grub3 commentedYes it works like a charm.
Comment #11
grub3 CreditAttribution: grub3 commentedWhat is the impact of this bug on database creation under PostgreSQL?
Should I delete the Drupal7 database and create a new one from scratch?
Comment #12
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks! :)
Comment #13
Damien Tournoud CreditAttribution: Damien Tournoud commentedComment #14
serenecloud CreditAttribution: serenecloud commentedAgreed with the above. After applying http://drupal.org/node/337794 and this patch I am able to run all simpletests on php5, apache2, postgres 8.1 without this error:
Final Simpletest output: