Module should use user_save instead of directly accessing drupal database (drupal6 patch)

rfay - December 1, 2008 - 14:12
Project:Role Delegation
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

This module uses direct database manipulation instead of using user_save, so other modules like Role Change Notify cannot interoperate with it (see #341126: Does not work with Role Delegation). user_save() is the preferred way to operate.

The attached drupal6 patch updates role_delegation to use user_save().

AttachmentSize
role_delegation_user_save_patch_drupal6.patch1.07 KB

#1

asak - February 13, 2009 - 16:36
Status:needs review» reviewed & tested by the community

This works, and helps with integration with Rules as well (so that triggers of "Profile is updated" execute when changing roles using Role Delegation).

#2

David Lesieur - March 3, 2009 - 01:29
Status:reviewed & tested by the community» fixed

Committed. Great improvement, thanks!

#3

David Lesieur - March 3, 2009 - 01:32
Version:6.x-1.0» 6.x-1.x-dev

#4

System Message - March 17, 2009 - 01:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.