This patch refactors the Automated Logout module and makes it work correctly. I was going to write a Drupal Tough Love review, but thought it might just be easier to just fix it. The result is less code:

This patch was made from the DRUPAL-6--1 branch, and I suggest you use it...

CommentFileSizeAuthor
autologoutrefactor.patch26 KBrobloach

Comments

jvandervort’s picture

jvandervort commented
Status: Reviewed & tested by the community » Needs review

Nice patch. I'll let the other devs review it as I'm just a part timer for automatedlogout. It changes so much of the functionality, it probably should be a new branch. It also isn't so much a bug report as it doesn't list any issues/bugs that it fixes.
I'm all for optimization, but the statement

Replacement of 550 line JavaScript Countdown Timer with 47 line jQuery Countdown.

is a bit misleading as Keith Wood's jquery countdown plugin is over 483 lines by itself not counting localization.

So +1 for new branch.

robloach’s picture

robloach
he/him
commented

Sounds good with me. Oh, and here's the module by itself without the patch:
http://drupalbin.com/4307

profix898’s picture

profix898 commented
Status: Needs review » Reviewed & tested by the community

Huge +1 on the refactored module code. Its much cleaner (the approach and the actual code) and simply WORKS.

jvandervort’s picture

jvandervort commented
Status: Reviewed & tested by the community » Fixed

Neither of the other committers visited this topic, so I committed most of this patch into the 6.x-3.x Branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.