Theme settings not saved since Forms API

fixed in // $Id: system.module,v 1.241 2005/10/13 10:02:31 unconed Exp $ use a cvs checkout not the tarball.

Other settings also are not saved, like:

• Shortcut icon settings
• Primary/Sconday link settings
• Display post information on checkboxes

Oct 18, 2005 CVS checkout.

Confirmed. The only settings which save on the admin/themes/settings page are the "Toggle display" checkboxes at the bottom.

This affects all themes.

(also confirmed on 25/10 HEAD)

i downloaded the current cvs-head of drupal
and tried to toggle things like "Secondary links" but nothing changed.

and at the tabs there are only this two links shown:
* global settings
* bluemarine

regardless if I activated more themes or if i unacitvated bluemarine...

after some clicking around the missing tabs got shown (I dont know what I did)
but now I disabled again some themes and the the tab does not get changed again

same problem mentioned here: http://drupal.org/node/33700

My head is spinning from this bug...is this open, closed, fixed; or a mixture of the above?

Robin

This still doesn't work!

For example:

• clean CVS install
  • system.module $Id: system.module,v 1.247 2005/10/26 01:24:09 unconed Exp
  • includes/form.inc - there is no $Id in this file, but it is version 1.8
• none (!) of the checkboxes of the theme settings form works (admin/theme/settings) as expected
• for example
  • the checkbox "Site slogan" is by default off
  • checking it and save => "Site slogan" is on (set)
  • unchecking it and save => "Site slogal" stays on (set)!
• my impression is that in _form_builder $_POST['edit']['toggle_site_slogan'] is not set (not present) which causes the function to set it to #default_value instead of to 0.
• so you can set toggles, but you can't unset them!

Either system.module uses form.inc wrongly, or there is something fundamentally wrong with form.inc concerning checkboxes.

I've looked into the checkboxes issue: http://drupal.org/node/35816

Also the "Reset to defaults" doesn't work:

• load admin/theme/settings
• for example set the "Site slogan" toggle
• press "Save configuration"
• the toggle is now set
• do "Reset to defaults"
• the toggle stays set
• reload the page (without resending the POST information) => the toggle is unset

So, the variable is unset (I have checked this with the "variable viewer" of devel.module), but when you press the "Reset to defaults" the form values are not filled in correctly!

I can confirm that the patch of #14 fixes the unsetting of a checkbox.

It doesn't fix the "Reset to defaults" issue (comment #15).

I have no clue whether the solution presented is a correct one.

I can also confirm the information in #16.

However, there is what appears to be another related issue with forms that is still not fixed.

To recreate:

1. Edit a node (Example /node/4/edit, number will vary, of course) that has been published to the front page.
2. In the publishing options, uncheck "Promoted to front page".
3. Click "Submit". The value in the database will change and the node will be removed from the front page.
4. Return to the edit page.
5. "Promoted to front page" defaults to checked, BUT the value in the database still reflects being unchecked.

So of course, it will reset any time you modify the node, but do not go and reset the check box.

I've tested this with story and poll, so it doesn't seem to be node type related. Similar behavior occurs with the other checkboxs on the page, such as "Sticky at top of lists", so it's not specific to the front page promotion option.

Tested using cvs as of today, php 5.0.5, MySQL 5.0.15, Apache 2.0.55, IE 6.

Please check the patch at http://drupal.org/node/35816 (mine, not asimmonds).

Reversed asimmonds' patch, applied chx's from http://drupal.org/node/35816, confirmed the same behavior as noted above.

I'm taking a look at it now.

Thomas' issue in #17 sounds very much like http://drupal.org/node/7940 ?

My issue in #17 is the same issue as http://drupal.org/node/7940 and apparently "By Design". I've added my comments about violating the "Principle of Least Astonishment" there on the side of those who want to change the design so that hidden options aren't unexpectedly reset.

In other words, similar behavior, but not the same bug as this issue (34170) is, so carry on.

This issues is no longer reproducible. Setting to fixed.