Download & Extend
Issues

Theme settings not saved since Forms API

Posted by Donovan on October 15, 2005 at 12:48pm
Project:Drupal core
Version:x.y.z
Component:theme system
Category:bug report
Priority:critical
Assigned:chx
Status:closed (fixed)

Issue Summary

I am using a CVS download from 10/12: // $Id: system.module,v 1.240 2005/10/11 19:44:35 dries Exp $

The theme *always* displays the default logo and *never* displays the site slogan after these options are deselected and selected (respectively).

To reproduce:

1) Go to: Administer/Themes/
2) Deselect "Use default logo" in Logo image settings area
3) Select "Site slogan" in Toggle display settings area
4) Save configuration
5) System responds with "The configuration options have been saved."

However, the options are not saved.

I am using the default installation with only the poormanscron contributed module added.

Login or register to post comments

Comments

#1

Posted by chx on October 15, 2005 at 12:49pm
Status:active» fixed

fixed in // $Id: system.module,v 1.241 2005/10/13 10:02:31 unconed Exp $ use a cvs checkout not the tarball.

#2

Posted by Donovan on October 15, 2005 at 2:19pm
Status:fixed» active

The problem persists with Default logo.

I updated modules, includes, etc. with latest CVS files: // $Id: system.module,v 1.241 2005/10/13 10:02:31 unconed Exp $

The Site slogan settings issue is fixed; but the Default logo settings still are not being saved.

#3

Posted by chx on October 16, 2005 at 4:21am
Assigned to:Donovan» chx

#4

Posted by gtcaz on October 18, 2005 at 11:11pm

Other settings also are not saved, like:

  • Shortcut icon settings
  • Primary/Sconday link settings
  • Display post information on checkboxes

Oct 18, 2005 CVS checkout.

#5

Posted by Thox on October 20, 2005 at 9:58am
Title:Default Logo and Site Slogan Settings not saved in with default Bluemarine theme» Default Logo and Site Slogan Settings not saved

Confirmed. The only settings which save on the admin/themes/settings page are the "Toggle display" checkboxes at the bottom.

This affects all themes.

#6

Posted by leafish_paul on October 25, 2005 at 3:08pm
Title:Default Logo and Site Slogan Settings not saved» Theme settings not saved since Forms API

#7

Posted by leafish_paul on October 25, 2005 at 3:09pm

(also confirmed on 25/10 HEAD)

#8

Posted by chx on October 26, 2005 at 1:30am
Status:active» fixed

#9

Posted by Tobias Maier on October 28, 2005 at 10:07pm

i downloaded the current cvs-head of drupal
and tried to toggle things like "Secondary links" but nothing changed.

and at the tabs there are only this two links shown:
* global settings
* bluemarine

regardless if I activated more themes or if i unacitvated bluemarine...

#10

Posted by Tobias Maier on October 28, 2005 at 10:24pm
Status:fixed» active

after some clicking around the missing tabs got shown (I dont know what I did)
but now I disabled again some themes and the the tab does not get changed again

#11

Posted by Tobias Maier on October 28, 2005 at 11:05pm

same problem mentioned here: http://drupal.org/node/33700

#12

Posted by Robin Monks on October 30, 2005 at 7:17pm

My head is spinning from this bug...is this open, closed, fixed; or a mixture of the above?

Robin

#13

Posted by Robrecht Jacques on October 31, 2005 at 9:24am

This still doesn't work!

For example:

  • clean CVS install
    • system.module $Id: system.module,v 1.247 2005/10/26 01:24:09 unconed Exp
    • includes/form.inc - there is no $Id in this file, but it is version 1.8
  • none (!) of the checkboxes of the theme settings form works (admin/theme/settings) as expected
  • for example
    • the checkbox "Site slogan" is by default off
    • checking it and save => "Site slogan" is on (set)
    • unchecking it and save => "Site slogal" stays on (set)!
  • my impression is that in _form_builder $_POST['edit']['toggle_site_slogan'] is not set (not present) which causes the function to set it to #default_value instead of to 0.
  • so you can set toggles, but you can't unset them!

Either system.module uses form.inc wrongly, or there is something fundamentally wrong with form.inc concerning checkboxes.

#14

Posted by asimmonds on October 31, 2005 at 9:39am

I've looked into the checkboxes issue: http://drupal.org/node/35816

#15

Posted by Robrecht Jacques on October 31, 2005 at 9:41am

Also the "Reset to defaults" doesn't work:

  • load admin/theme/settings
  • for example set the "Site slogan" toggle
  • press "Save configuration"
  • the toggle is now set
  • do "Reset to defaults"
  • the toggle stays set
  • reload the page (without resending the POST information) => the toggle is unset

So, the variable is unset (I have checked this with the "variable viewer" of devel.module), but when you press the "Reset to defaults" the form values are not filled in correctly!

#16

Posted by Robrecht Jacques on October 31, 2005 at 9:45am

I can confirm that the patch of #14 fixes the unsetting of a checkbox.

It doesn't fix the "Reset to defaults" issue (comment #15).

I have no clue whether the solution presented is a correct one.

#17

Posted by Thomas Sewell on November 1, 2005 at 8:22pm

I can also confirm the information in #16.

However, there is what appears to be another related issue with forms that is still not fixed.

To recreate:

1. Edit a node (Example /node/4/edit, number will vary, of course) that has been published to the front page.
2. In the publishing options, uncheck "Promoted to front page".
3. Click "Submit". The value in the database will change and the node will be removed from the front page.
4. Return to the edit page.
5. "Promoted to front page" defaults to checked, BUT the value in the database still reflects being unchecked.

So of course, it will reset any time you modify the node, but do not go and reset the check box.

I've tested this with story and poll, so it doesn't seem to be node type related. Similar behavior occurs with the other checkboxs on the page, such as "Sticky at top of lists", so it's not specific to the front page promotion option.

Tested using cvs as of today, php 5.0.5, MySQL 5.0.15, Apache 2.0.55, IE 6.

#18

Posted by chx on November 1, 2005 at 8:31pm

Please check the patch at http://drupal.org/node/35816 (mine, not asimmonds).

#19

Posted by Thomas Sewell on November 1, 2005 at 8:43pm

Reversed asimmonds' patch, applied chx's from http://drupal.org/node/35816, confirmed the same behavior as noted above.

#20

Posted by adrian on November 1, 2005 at 9:07pm

I'm taking a look at it now.

#21

Posted by asimmonds on November 1, 2005 at 10:25pm

Thomas' issue in #17 sounds very much like http://drupal.org/node/7940 ?

#22

Posted by Thomas Sewell on November 1, 2005 at 11:07pm

My issue in #17 is the same issue as http://drupal.org/node/7940 and apparently "By Design". I've added my comments about violating the "Principle of Least Astonishment" there on the side of those who want to change the design so that hidden options aren't unexpectedly reset.

In other words, similar behavior, but not the same bug as this issue (34170) is, so carry on.

#23

Posted by Steve Dondley on January 11, 2006 at 6:10am
Status:active» fixed

This issues is no longer reproducible. Setting to fixed.

#24

Posted by Anonymous on January 25, 2006 at 9:07am
Status:fixed» closed (fixed)