Hi, I'm using BUEditor and have assigned some roles to a default editor. no overlapping roles for my users. I noticed that BUEditor doesn't show on node editing. Further investigations results in a wrong weight management for editors/roles.
The weight is sorted with some "unsigned" comparison, and for "authenticated" and "anonymous" roles weight isn't stored in BUEditor variables.

Regards

Comments

thepanz’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new1.25 KB

Fixed weight sorting function and storing DRUPAL_AUTHENTICATED_RID and DRUPAL_ANONYMOUS_RID into BUEditor variables.

ufku’s picture

Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new772 bytes

below patch has been committed. thanks.

aleksey.tk’s picture

The patch you commit doesn't fix anything. Actually the patch from thePanz (the first one) fixing this bug. In the commit comment you said that you applied patch from thePanz, but looking at the diff i can say that this is not right, you applied another patch you attached to last comment. Please check this out!

ufku’s picture

You should submit the role-editor assignment form at least once. Then it should work as expected. Actually, without patching you could also achieve the desired behaviour using negative values.

aleksey.tk’s picture

Status: Fixed » Active

I was talking about this commit:

Commit #168080 by ufku at 20:28
BUEditor: /modules/bueditor/bueditor.admin.inc 1.3.2.3 @ DRUPAL-6--1
- #341788 by thePanz: fixed sorting of role weights

This doesn't fix the bug. Please, check this out!

P.S. Sorry for my english, it is not my native language

aleksey.tk’s picture

Status: Active » Fixed

Hmm, looks like your patch fixing this issue. Sorry for trying to mislead you... but your commit comment was really confusing.

ufku’s picture

Nice to hear it's working. With a few simplifications it's still thePanz's patch inside ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.