Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There are a handful of work-arounds I put into date.inc to deal with bugs and limitations of the current official releases of DateAPI and CCK date fields. Once 6.x-2.0-rc6 and 5.x-2.5 are out of Date module, these work-arounds can be removed from the signup code. Oh, and look at that... date 6.x-2.0-rc6 is now out. ;) Yay...
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 341920-signup-date.patch | 5.28 KB | ezra-g |
| #6 | 341920_no_date_hacks.6.d6.patch | 4.99 KB | Eirik_R |
| #2 | 341920_no_date_hacks.2.d5.patch | 4.87 KB | dww |
| #1 | 341920_no_date_hacks.1.d6.patch | 4.91 KB | dww |
Comments
Comment #1
dwwUntested, but something like this for D6.
Comment #2
dwwStill untested, but here's a backport to DRUPAL-5--2 for after #341980: Create a date 5.x-2.5 release is done.
Comment #3
dwwdate 5.x-2.5 is now out if anyone wants to give this a try...
Comment #4
dwwTested these. I had a typo in here from a bad function name, now fixed.
However, 5.x-2.5 has a critical bug for this stuff: #346804: Fatal error in date_field_get_sql_handler(): module_load_include() is D6-only, so this will have to be postponed until date 5.x-2.6, which will probably be a while.
Comment #5
dwwDate's up to 5.x-2.7 and 6.x-2.1 now. ;) Anyone care to test these patches with the latest official date releases and report their findings?
Comment #6
Eirik_R commentedI applied the patch for d6 with signup6 from cvs and most recent date. Have found no problems yet. Setting RTBC, which thus applies to the d6 patch. By reading the code I assume this could apply to d5 as well.
I do have one objection/question before actual committing, can it be assumed that sites using date will be up to date?
The patch I've attached is the same as the original, I've just updated the line numbers.
Comment #7
ezra-g commentedWould love to commit this but after applying and running cron I get:
[28-Dec-2010 23:18:43] PHP Fatal error: Call to undefined method date_sql_handler::date_sql_math() in /Users/ezra/Developer/htdocs/dev/contrib/cod4/sites/all/modules/contrib/signup/includes/date.inc on line 318
Comment #8
ezra-g commentedHere's a re-roll that uses the correct method. Will do some additional testing but plan to commit this tonight since it's straightforward and helps us reduce code before the D7 update of Signup :).
Comment #9
ezra-g commentedI tested that via cron, with this patch applied, Signup correctly closed an event after it took place and left open another event that had not yet taken place. Committed. Thanks!
http://drupal.org/cvs?commit=471156