Closed (fixed)
Project:
Project
Version:
5.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Dec 2008 at 02:19 UTC
Updated:
19 Dec 2008 at 19:22 UTC
Jump to comment: Most recent file
I think while working on #310446: Remove issue creation links from project pages, someone in IRC suggested that we move to a 3 column layout for the pile-o-links on project nodes. Seems like a better use of space. I'm working on this will trying to sync DB tables between d.o and p.d.o to test #326197: Empty data for latest week. Stay tuned for a patch and screenshot.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 342476_project_links_3_column.9.patch | 467 bytes | dww |
| #4 | Picture 1.png | 65.61 KB | morbus iff |
| #2 | 342476_project_links_3_column.2.patch | 2.04 KB | dww |
| #1 | 342476_project_links_3_column.1.patch | 2.03 KB | dww |
| #1 | 342476_project_links_3_column.1.png | 95.12 KB | dww |
Comments
Comment #1
dwwLike so: http://project.drupal.org/project/drupal (might need to shift reload)
See attached screenshot and patch.
There's one minor hack in the patch -- if a link section includes
'clear' => TRUEwe output a<br style="clear:both" />after it. The is so that the 3 column stuff starts after the links for the release table, since that just seemed weird to be the first column. Suggestions for better ways to handle this would be welcome -- my fairly limited CSS fu is shining through here. ;)Comment #2
dwwSlightly clearer patch, minor CSS tweaks.
Comment #3
dwwCommitted to HEAD + DRUPAL-5, deployed on p.d.o and d.o.
Comment #4
morbus iffDoesn't fit on my regular browsing resolution (1010px wide, as set by Web Developer Toolbar).
Comment #6
morbus iffOnly happens for me when "Try out a demonstration" is enabled on first column.
(Project project page is fine, bot or cumulus project page isn't, for instance).
Comment #7
morbus iffSwitching padding-right: 2em; to 1.4em fixes it for me, at least - 1.5em is too much.
Comment #8
morbus iffAs for your hack in #1, you may be able to fix it by just adding "clear-block" to the class list for
<div id="project-links-section-project_release" class="project-links-section CLEAR-BLOCK-GOES-HERE">I have not tested it.Comment #9
dwwre: #4: Shift-reload and see if you like it.
re: #8: Nope, I tried that early on and it didn't work, so I went for the br.
Comment #10
morbus iff#4: yep, dandy.
#8: Hrm. Ok. Put a DIV around the three blocks and put the clear-block on the new DIV.
Comment #11
dww#8 right, but it's not just 3 blocks in general. There's a hook for modules to add/alter these link sections, etc. We have no idea ahead of time how many and what order they're in. What's there works and it's relatively simple in the code. I'm done worrying about it.
Meanwhile, I committed #9 to HEAD + DRUPAL-5, and deployed officially on d.o and p.d.o.