By default, blocks use the block delta as part of the block's ID attribute, but this creates IDs that are inaccessible via CSS because jump.module uses a colon (:) in the block delta. This patch fixes this problem.

Block IDs before this patch
#block-jump-menu:menu-name

After this patch
#block-jump-menu-menu-name

CommentFileSizeAuthor
#3 block-delta-fix.2.patch2.13 KBevoltech
block-delta-fix.patch1.01 KBjoshuajabbour

Comments

evoltech’s picture

evoltech commented
Status: Needs review » Reviewed & tested by the community

I was able to apply this to the DRUPAL-6--1 branch and verified that it fixes the stated issue.

marcp’s picture

marcp commented
Status: Reviewed & tested by the community » Needs work

I think we're going to need an update function to convert jump block deltas (delta column in the blocks table) from, say "menu:navigation" to "menu-navigation" -- unless that gets done automatically (I haven't yet tested).

To test this, with 6.x-1.0, configure a jump menu block. Then, apply the patch. Does the previously configured jump menu block still work?

evoltech’s picture

evoltech commented
StatusFileSize
new block-delta-fix.2.patch2.13 KB

Well the jumps still work, but they don't have the newly formatted classes attached to them. This patch includes changes to jump.install to upgrade existing menus created with the jump module.

marcp’s picture

marcp commented
Status: Needs work » Fixed

Thanks, evoltech. Committed with a few minor modifications. This will get into the next release along with a few other issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.