Download & Extend

Print warning message after branch creation to update workspace

Project:CVS integration
Version:5.x-1.x-dev
Component:X-CVS scripts
Category:feature request
Priority:normal
Assigned:dww
Status:closed (fixed)

Issue Summary

People all the time forget that running cvs tag -b DRUPAL-6--1 creates a branch but doesn't update their workspace to use the new branch automatically (for example #344016: CVS quickstart doesn't remind people after they create a branch to update their workspace). Although many CVS GUIs are evil and don't present the messages generated in our validation scripts, we could at least help CLI users and some GUI users by reminding them after they create a branch to update their workspace.

Comments

#1

Status:active» needs review
AttachmentSize
344234_xcvs_branch_message.1.patch 1.4 KB

#2

Fixed typo. Still untested.

AttachmentSize
344234_xcvs_branch_message.2.patch 1.4 KB

#3

Well, this works, but sadly:

A) The messages are generated for each directory you're branching, and

B) The messages are printed *before* all the output from the tag itself.

So, on big directory trees, it's still possible to miss it. Here's test output from tagging contributions/modules/signup on the p.d.o CVS repo:

$ cvs tag -b DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
** NOTE: Don't forget that creating a branch does NOT
** automatically update your workspace to use that branch.
** If you want to commit to this new branch, you must run:
** cvs update -r DRUPAL-6--1
cvs tag: Tagging .
T CHANGELOG.txt
T INSTALL.txt
T README.txt
T UPGRADE.txt
T signup.css
T signup.info
T signup.install
T signup.module
cvs tag: Tagging contrib
cvs tag: Tagging contrib/signup_conflicts
cvs tag: Tagging contrib/signup_ecommerce
cvs tag: Tagging includes
T includes/admin.settings.inc
T includes/admin.signup_administration.inc
T includes/broadcast.inc
T includes/cron.inc
T includes/date.inc
T includes/event.6x-2.inc
T includes/no_views.inc
T includes/node_admin.inc
T includes/node_admin_summary.inc
T includes/node_form.inc
T includes/node_output.inc
T includes/node_settings.inc
T includes/scheduler.inc
T includes/signup_cancel_form.inc
T includes/signup_form.inc
T includes/token_help.inc
cvs tag: Tagging js
T js/admin.content_types.js
T js/admin.settings.js
T js/node_form.js
cvs tag: Tagging panels
T panels/README.txt
cvs tag: Tagging panels/content_types
T panels/content_types/signup_form.inc
cvs tag: Tagging po
cvs tag: Tagging theme
T theme/README.txt
T theme/admin.inc
T theme/email.inc
T theme/no_views.inc
T theme/node.admin.inc
T theme/node.inc
T theme/signup_form.inc
cvs tag: Tagging translations
T translations/da.po
T translations/de.po
T translations/es.po
T translations/fr.po
T translations/ja.po
T translations/nb.po
T translations/signup.pot
cvs tag: Tagging views
T views/README.txt
T views/signup.views.inc
T views/signup.views_default.inc
cvs tag: Tagging views/handlers
T views/handlers/signup_handler_argument_signup_user_uid.inc
T views/handlers/signup_handler_field_signup_send_confirmation.inc
T views/handlers/signup_handler_field_signup_status.inc
T views/handlers/signup_handler_field_signup_user_email.inc
T views/handlers/signup_handler_field_signup_user_form_data.inc
T views/handlers/signup_handler_filter_boolean.inc
T views/handlers/signup_handler_filter_signup_disabled.inc
T views/handlers/signup_handler_filter_signup_status.inc
T views/handlers/signup_handler_filter_signup_user_authenticated.inc
cvs tag: Tagging views/plugins
T views/plugins/signup_plugin_argument_validate_signup_status.inc

#4

+1 from me. Maybe it won't help everyone if it's up too high and gets missed by some but if it saves even one person frustration, it's worth it.

Michelle

#5

Status:needs review» fixed

Committed to HEAD, DRUPAL-5, and deployed on cvs.d.o.

#6

Thanks, dww!

Michelle

--project followup subject--

Automatically closed -- issue fixed for two weeks with no activity.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.