I'm trying to use this module to allow users to change the "Publishing options": "Published" and "Promoted to front page" for their own content. While this works in itself, every time a user now edits his own content and saves it again, the "authored by" information becomes erased and is then displayed by Drupal as "Anonymous".

I've verified that this is indeed cause by "Override Node": If I disable this module, the "authored by" information is not erased when a user updates one of his nodes.

I also found a workaround: if I additionally give users the permission to "override blog authored by option", the "authored by" information is not erased.

A similar problem happens with "authored on", if the user has permission to change it. I noticed that when hitting "Preview", the "authored on" information becomes erased (blank).

Comments

timmillwood’s picture

Thanks I will look into it and try to get a new release out ASAP.

TUc’s picture

StatusFileSize
new877 bytes

I can confirm this issue.

I wrote a patch for it. It checks whether $node->override_authored_by is set.

timmillwood’s picture

Status: Active » Needs review
timmillwood’s picture

Status: Needs review » Fixed

committed

domesticat’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Fixed » Active

I'm not sure this is fixed. Installing 6.x-1.7 actually caused this problem to start for me. Since the April 7 dev release, anyone that I've given "override [nodetype] authored by option" permission to is having their posts saved as Anonymous by default, even though anonymous users can't create content on the site.

Hoping someone else can confirm the problem.

Correction: I originally marked this as 6.x-dev, but in fact the version is 6.x-1.7.

domesticat’s picture

Version: 6.x-1.x-dev » 6.x-1.7
timmillwood’s picture

Assigned: Unassigned » timmillwood

ok, I see the issue. I'll look into it.

Should just need a simple 'if' statement somewhere.

timmillwood’s picture

Status: Active » Fixed

Fixed in Version 6.x-1.8

philsward’s picture

Version: 6.x-1.7 » 6.x-1.8
Assigned: timmillwood » Unassigned

Should I re-open this issue or create a new one? I installed 1.8 last night from 1.4 (I think 1.4), and I am having this same issue. It doesn't appear to be fixed yet...

The ONLY option I have turned on, is "override post publish" (post being the content type I have setup)

Any ideas?

Flying Drupalist’s picture

Yep, this is not fixed. I can confirm this bug. I think I'll downgrade for now, to... 1.6?

rene_w’s picture

No point in downgrading: 1.6 was the version I originally reported the bug against.

Flying Drupalist’s picture

Status: Fixed » Active

I was using this module for a while, and the bug came for me in a recent version. I only hope this gets fixed fast though.

leeneman’s picture

This bug does not appear to be limited to the "Authored by" information. Also the "authored on" information seems to be reset to the current date and time. The solution for me was to roll-back to 1.4

timmillwood’s picture

ok, I had it working, so can we clarify the bug and I'll go back and check

Authored by field
- When the user does not have the "Override authored by" permission it gets set to Anonymous rather than their username (and on preview?).
- When the user does have the "Override authored by" permission it doesn't save the overridden value or their username (and on preview?)

Authored on field
- When the user does have the "Override authored on" permission it doesn't save the overridden value (and on preview?).

I'll try to take a look today, if you can feed back with specific bugs (from the list above, or not) that would be great, and patches would be better.

Thanks

timmillwood’s picture

Status: Active » Fixed

I hope this is all fixed in version 6.x-1.9

gunzip’s picture

Status: Fixed » Active

i think that it should leave the 'created' ($node->created) value unaltered on save if "authored on" is hidden.
with 6.x-1.9 i get that parameter overwritten every time i save the node so created becomes => changed.

mindgame’s picture

I'm using 6.x-1.9 and I can confirm #16.

I changed line #259 from

$node->created = !empty($node->override_authored_on) ? strtotime($node->override_authored_on) : time();

to

if (!empty($node->override_authored_on)) $node->created = strtotime($node->override_authored_on);
Tom Freudenberg’s picture

Version: 6.x-1.8 » 6.x-1.9
StatusFileSize
new1.29 KB

Please see follwing patch which is for fine for us when using 6.x-1.9

timmillwood’s picture

Status: Active » Needs review

Tom,

Thanks for the patch.

I hope to test it this week, and will then commit. If anyone else could test this would be great.

mr.alinaki’s picture

Last posted patch works fine! Thank you, Tom Freudenberg!

petednz’s picture

sub - sounds like my search for this may be easy once the commit is made - thanks to all for sorting this - one thing off the list - back to the list

frjo’s picture

Status: Needs review » Reviewed & tested by the community

I have the same problem as #16 and the patch in #18 fixes it for me.

timmillwood’s picture

Status: Reviewed & tested by the community » Fixed

Committed to branch DRUPAL-6--1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

daniel wentsch’s picture

It seems that this problem still occurs when using domain access.
On every but the default domain the authored by information is not being saved if a user doen't have permission to alter this field.

daniel wentsch’s picture

Okay, found out it was a different bug in Domain Admin module:
#859538: Content submitted by role "Editor" is marked "Submitted by Anonymous"

1.x. dev of domain admin fixed the issue.