Override Node erases "Authored by" information

rene_w - December 14, 2008 - 00:43
Project:Override Node Options
Version:6.x-1.9
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I'm trying to use this module to allow users to change the "Publishing options": "Published" and "Promoted to front page" for their own content. While this works in itself, every time a user now edits his own content and saves it again, the "authored by" information becomes erased and is then displayed by Drupal as "Anonymous".

I've verified that this is indeed cause by "Override Node": If I disable this module, the "authored by" information is not erased when a user updates one of his nodes.

I also found a workaround: if I additionally give users the permission to "override blog authored by option", the "authored by" information is not erased.

A similar problem happens with "authored on", if the user has permission to change it. I noticed that when hitting "Preview", the "authored on" information becomes erased (blank).

#1

timmillwood - December 14, 2008 - 20:04

Thanks I will look into it and try to get a new release out ASAP.

#2

TUc - January 28, 2009 - 15:33

I can confirm this issue.

I wrote a patch for it. It checks whether $node->override_authored_by is set.

AttachmentSize
override_node_options.346748.D6.x-1.patch 877 bytes

#3

timmillwood - January 28, 2009 - 18:00
Status:active» needs review

#4

timmillwood - April 3, 2009 - 20:58
Status:needs review» fixed

committed

#5

domesticat - April 9, 2009 - 12:36
Version:6.x-1.0» 6.x-1.x-dev
Status:fixed» active

I'm not sure this is fixed. Installing 6.x-1.7 actually caused this problem to start for me. Since the April 7 dev release, anyone that I've given "override [nodetype] authored by option" permission to is having their posts saved as Anonymous by default, even though anonymous users can't create content on the site.

Hoping someone else can confirm the problem.

Correction: I originally marked this as 6.x-dev, but in fact the version is 6.x-1.7.

#6

domesticat - April 9, 2009 - 12:37
Version:6.x-1.x-dev» 6.x-1.7

#7

timmillwood - April 9, 2009 - 13:15
Assigned to:Anonymous» timmillwood

ok, I see the issue. I'll look into it.

Should just need a simple 'if' statement somewhere.

#8

timmillwood - April 9, 2009 - 13:44
Status:active» fixed

Fixed in Version 6.x-1.8

#9

philsward - April 10, 2009 - 18:44
Version:6.x-1.7» 6.x-1.8
Assigned to:timmillwood» Anonymous

Should I re-open this issue or create a new one? I installed 1.8 last night from 1.4 (I think 1.4), and I am having this same issue. It doesn't appear to be fixed yet...

The ONLY option I have turned on, is "override post publish" (post being the content type I have setup)

Any ideas?

#10

Flying Drupalist - April 10, 2009 - 21:05

Yep, this is not fixed. I can confirm this bug. I think I'll downgrade for now, to... 1.6?

#11

rene_w - April 10, 2009 - 22:51

No point in downgrading: 1.6 was the version I originally reported the bug against.

#12

Flying Drupalist - April 10, 2009 - 22:58
Status:fixed» active

I was using this module for a while, and the bug came for me in a recent version. I only hope this gets fixed fast though.

#13

leeneman - April 10, 2009 - 23:13

This bug does not appear to be limited to the "Authored by" information. Also the "authored on" information seems to be reset to the current date and time. The solution for me was to roll-back to 1.4

#14

timmillwood - April 11, 2009 - 08:41

ok, I had it working, so can we clarify the bug and I'll go back and check

Authored by field
- When the user does not have the "Override authored by" permission it gets set to Anonymous rather than their username (and on preview?).
- When the user does have the "Override authored by" permission it doesn't save the overridden value or their username (and on preview?)

Authored on field
- When the user does have the "Override authored on" permission it doesn't save the overridden value (and on preview?).

I'll try to take a look today, if you can feed back with specific bugs (from the list above, or not) that would be great, and patches would be better.

Thanks

#15

timmillwood - April 11, 2009 - 11:59
Status:active» fixed

I hope this is all fixed in version 6.x-1.9

#16

gunzip - April 24, 2009 - 12:22
Status:fixed» active

i think that it should leave the 'created' ($node->created) value unaltered on save if "authored on" is hidden.
with 6.x-1.9 i get that parameter overwritten every time i save the node so created becomes => changed.

#17

mindgame - May 27, 2009 - 21:14

I'm using 6.x-1.9 and I can confirm #16.

I changed line #259 from

$node->created = !empty($node->override_authored_on) ? strtotime($node->override_authored_on) : time();

to
if (!empty($node->override_authored_on)) $node->created = strtotime($node->override_authored_on);

#18

Tom Freudenberg - July 19, 2009 - 18:41
Version:6.x-1.8» 6.x-1.9

Please see follwing patch which is for fine for us when using 6.x-1.9

AttachmentSize
override_node_options.module.patch 1.29 KB

#19

timmillwood - July 19, 2009 - 18:47
Status:active» needs review

Tom,

Thanks for the patch.

I hope to test it this week, and will then commit. If anyone else could test this would be great.

#20

Mr.Alinaki - July 22, 2009 - 21:10

Last posted patch works fine! Thank you, Tom Freudenberg!

#21

peted - July 22, 2009 - 22:08

sub - sounds like my search for this may be easy once the commit is made - thanks to all for sorting this - one thing off the list - back to the list

#22

frjo - July 27, 2009 - 09:36
Status:needs review» reviewed & tested by the community

I have the same problem as #16 and the patch in #18 fixes it for me.

#23

timmillwood - July 27, 2009 - 12:25
Status:reviewed & tested by the community» fixed

Committed to branch DRUPAL-6--1.

#24

System Message - August 10, 2009 - 12:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.