Hey Chris,

Sorry to have been MIA this week, just overwhelmed with work, technical problems and the weather.

Anyways, I ran into some issues with the site I'm working on, and decided the best thing to do is upgrade the whole thing to Drupal 6 (all of the other needed modules at least have dev versions now for Drupal 6.)

Upon doing this though, I'm getting the error "Drupal" is undefined error, line 16 iepngfix.htc.

I thought this variable Drupal.settings.basePath should be automatically created when drupal_add_js is called.

I can't figure why it wouldn't be generated, or if it is, why it isn't being used. I'll do some testing tomorrow to see if I can track this down. But this is a clean install of Drupal 6.8, Behave! 6x-1.5, and very few other modules.

Just thought I would let you know that there may be issues using this, and it might be safer to generate the base_path variable like it has to be done in Drupal 5 version.

BTW, thanks for tweaking that in http://drupal.org/node/344762

Steve

P.S. I like the new feature of adding the ability to exclude selectors.

CommentFileSizeAuthor
#1 BlankImgPath.patch1.85 KBFreshNewAndInView

Comments

FreshNewAndInView’s picture

FreshNewAndInView commented
StatusFileSize
new BlankImgPath.patch1.85 KB

can you test the patch i've attached here and let me know how it works for you? if it's good, then we can release 5.x-1.8 and 6.x-1.7 (6.x-1.6 is a hidden release) with the new proper path setting.

mrjeeves’s picture

mrjeeves commented
Assigned: Unassigned » mrjeeves
Status: Active » Needs review

the above was posted by me, forgot to sign off of my roommates account.

wickwood’s picture

wickwood commented

Yes, this works for me.

Funny thing is, I just finished making exactly the same changes to the code that you posted in this patch, and was coming back here to post the changes.

I still can't figure out why the original doesn't work though. I'm guessing that it has something to do with when this script is called relative to when any other drupal_add_js is called. I'm thinking that if the this module is called before any other use of drupal_add_js, then there is a problem because then the Drupal.settings.basePath is not set yet as I understand it.

I think doing things the way you have done here is better because it is more explicit as to how the base-path for the blank image is derived.

Still need to get my CVS working, hope to get that done sometime this week.

Steve

mrjeeves’s picture

mrjeeves commented
Status: Needs review » Fixed

The patch has been committed to the 6.x-1.7 official release, marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.