Post settings when ping'ing drupal via custom url

I was able to fix the no title problem, but I had to add code to the pingfm.module.

Ping.fm will only pass a title if the service supports which is only "blog"... I wanted to be able to pass status messages to my site with a default title. So I changed the following in pingfm.module at line 193

        /**
         * added by chuck to fix the lack of title.  Should only change title if no title is provided.
         */
        if (is_Null($title)) {
          $title = "ping.fm update for " . $user->name; 
        }
        $node = array(
          'title' => $title,
          'uid' => $user->uid,
          'name' => $user->name,
          'body' => $message,
          'type' => $user->pingfm_customurl_nodetype,
          'promote' => 1,
        );

I also attached my updated pingfm.module file.

What if we just got the first 50ish characters of the node teaser if the title isn't there?

Because I am currently snowed in... I have continued to poke around with this module. Did a few more updates. I guess now I need to figure out how to submit back to the project... All though I am sure the code is not good, but it does work.

* User can configure the default title and use "!user" variable in the title
* Default title is only used if no title is passed from ping.fm
* User can set the promote option to on or off

I am working now on trying to allow the admin to override these user settings and force the promote on or off, and force the title format.

*update pingfm.module is attached.

Would be a good option if some one is using ping.fm to submit a full blog entry or a large microblog. However the smaller status messages that can come from ping.fm are often smaller than 50ish...

With that said, it could be one of the options. Such as "Use first X chars if body is more than X characters"? not sure...

Chuck

Attached are two patch files that cover all the changes that have been made including from chrissearle to default the promote option to the nodetype properties.

Updates:
* All user to set the default title format
+ can use "!user" as replacement text
* Admin option to allow user to override nodetype promote setting
* User option to force promote (only viewable if admin allows)
* defaults promote to nodetype settings unless admin allows override and user has set the override.

I ran through several tests but with out any problems... but I am sure there is something I didn't think of.

Hi Chuck. Nicely done with the patch! Thanks for having a look at this. There are a couple things I'd love tweaked before this goes in:

1. "User override promote" doesn't really sound very descriptive. Would "Allow posting to front page". "When enabled, will allow users to send posts made with Ping.fm to the front page."... Does that make more sense?
2. We don't need the authoring code comments in there. The CVS commit messages credit you ;-) .
3. Could we use "is_null" instead? We want to stick with the Drupal coding standards ;-) .
4. Instead of checking if ( variable_get('pingfm_prom_ovr', FALSE) == TRUE ) in the user options, you could just use '#access' => variable_get('pingfm_prom_ovr', FALSE) :-)... YAY Drupal!

Awesome work, Chuck! This is looking pretty slick. Once those changes are in, I think it should be commit ready. :-) Keep it up!

Thanks Rob... I will make the changes tonight and update.

Hey Rob,

quick question on number 3...

3) Could we use "is_null" instead? ....
- What did you want to replace with the is_Null? would it be instead of isset?
* sorry if this is an obvious question, new to coding with Drupal. :-)

1 - changed the wording to your suggestion. This does make more sense

2 - comments removed.

4 - OK... that is so much cleaner. Yay Drupal indeed!

Thanks, Chuck

if I download the current dev version do I need to apply these patches being discussed here, or they've been rolled in?

They have not been rolled in as of yet. So if you need the extended features and small fixes, then you should apply the patch.

I like what you did here but when I look at the module's code it looks like it has changed since you made these fixes, have you updated the patch for the new module version?

Using custom URL from Ping.fm capability will be updated with the following.

1. We will check the content type's default settings to determine if the node being created needs to be published or have comments on the node.
2. If there isn't a title passed we will generate one from the body text or the suggestion from #5.

Due to this issue being around 3 years old I'm changing the status to closed.