Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.On my website all comments need admin approval.
When I try to delete a comment (which was previously approved), the rating stays.
E.g. I can have all comments being deleted, but the Fivestar rating will remain untouched.
Thank you.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 349900.patch | 1.25 KB | ezra-g |
Comments
Comment #1
Timur5 commentedI desperately need a fix, even a dirty one, or at least a direction where it all happens, so I can try to think of a tailor made quick fix.
(P.s. I temporary solved the problem of double votes on admin approved comments (http://drupal.org/node/331446 ) by simply dividing the final value by two. Logic: since all votes come double (all comments are approved by admin), we can divide the value by two without losing the sense behind data.
Now I'm stuck not able to delete the vote, which affects overall rating :(
Comment #2
ezra-g commentedI looked into this and found that the vote id was not specified when votes were inserted into the fivestar_comment table, causing comment-cast ratings to not be deleted. A patch is attached. Would be great to get someone's review here.
Also, marked #583932: Deleting comment does not delete rating a dupe of this.
Comment #3
ezra-g commentedComment #4
ezra-g commentedActually, I think Fivestar just missed some updates to follow the VotingAPI and this is RTBC. Sadly, I'm having issues with my CVS account at the moment so I'll have to come back and commit this soon.
Comment #5
ezra-g commentedThis is now committed. Catch it in the latest dev release after the next one is rolled.
Comment #6
ezra-g commentedJust wanted to cross reference #664446: Remove invalid data from fivestar_comment, votingapi_votes tables. for folks who experienced this issue, since you may want to remove the old invalid data from your database.
Comment #7
Timur5 commentedI'm stupid, never mind the comments below. I forgot to update the fivestar to new version before applying the patch. I'll get back with the feedback as soon as I'm done.
--------------
tried the 349900.patch, it didn't produce expected results, unfortunately.What I expected was: an non authenticated user leaves a 5 star comment. The comment requires approval by administrator.Yet, an non-approved comment has already cast the vote and 5 stars are visible to all visitors. (not a problem so far).
The administrator comes to delete the 5 star comment, and deletes it (without ever approving it). But, here is the problem, the casted vote isn't deleted, it stays.I thought the patch was trying to address this issue, or may be I'm missing the point?
I also tried approving the comment, and then deleting it, same trouble - the vote stays while the page no longer has any comments to it.-------------
Comment #8
Timur5 commentedIt works!!!
After updating to 6.x-1.19 and applying the 349900 patch the anonymous comments+rating are deleted entirely when Admin comes to moderate the comments.
This will work only if Admin never approved the comment. If, however, the comment was approved and you want to delete it later, we have the old problem (which I know requires a lot of work and is still pending to the fix) - the voting saves two votes and only one will be deleted.
Happy new year!!!
Thank you everyone, great work!
Comment #9
ezra-g commentedThanks for reporting here. As it turns out, this appears to be a duplicate of #601160: Comment-cast ratings not deleted with comment -- I missed the patch there because it was marked NW, but it addresses the fixes in this patch and changes an additional line. I'll follow up in that issue.