When I try to mark and email address in active, I receive these two errors: 

* warning: implode() [function.implode]: Invalid arguments passed in /home/sdoud/public_html/sites/all/modules/simplenews/simplenews.module on line 1658.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: UPDATE simplenews_subscriptions SET a_status = 0 WHERE snid IN() in /home/sdoud/public_html/includes/database.mysql.inc on line 174.

Any help would be appreciated.

CommentFileSizeAuthor
#10 simplenews.350531_1.patch1.16 KBsutharsan
#1 simplenews.350531.patch1.6 KBsutharsan

Comments

sutharsan’s picture

sutharsan commented
Category: support » bug
Status: Active » Needs review
StatusFileSize
new simplenews.350531.patch1.6 KB

Its a bug, the attached patch fixes it. Please test and report back.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Suppose better to check is there parameters at all... and only then try to modify data!

sutharsan’s picture

sutharsan commented

That's what the patch does. Tested it?

ridolfidesigns’s picture

ridolfidesigns commented

Hi,

I don't know if I am doing something wrong but I can never get patches to take. I always get an error. I follow the "how to patch" tutorial on here but I always seem to get an error.

Is there another place that tells how to patch so I can test to see if this works?

Thanks,

Eric

sutharsan’s picture

sutharsan commented

This is the handbook page which explains it: http://drupal.org/patch/apply
However with a small patch like this you could also do it by hand.

ridolfidesigns’s picture

ridolfidesigns commented

How would I do it by hand?

Thanks,

Eric

sutharsan’s picture

sutharsan commented

Open the patch and the target module in a plain text editor. Remove the lines of code marked with - add the lines marked with + The patch lists line numbers and preceding code to help you locate the right lines. Save the module.

ridolfidesigns’s picture

ridolfidesigns commented
Status: Needs review » Fixed

Thank you very much, I patched the module and it fixed it.

sutharsan’s picture

sutharsan commented
Status: Fixed » Reviewed & tested by the community

Fixed is not the right state for a bug report, it has not been committed yet. (If it was a support request it was Ok for you to marked it fixed.)

sutharsan’s picture

sutharsan commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new simplenews.350531_1.patch1.16 KB

By mistake the patch contained an other fix too. The attached patch is correct and is now committed.

ridolfidesigns’s picture

ridolfidesigns commented

The problem is fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.