In my node edit form, I have two HS taxonomy forms under a "Vocabularies" collapsible fieldset. Normally this fieldset is open by default and everything works properly, but I did a hook_form_alter to make the fieldset collapsed by default ($form['taxonomy']['#collapsed'] = TRUE;) and this makes the form be some where in between the javascript enabled and disabled forms. Two remove buttons appear for already selected elements and the table is formatted like the non javascript format but as soon as a javascript action is used it all goes to the javascript enabled form.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | collapse-5.x.3.x.dev_.patch | 487 bytes | bluetegu |
| #3 | collapse-6.x.3.x.dev_.patch | 487 bytes | bluetegu |
Comments
Comment #1
bluetegu commentedYes, I have the same problem in 5.x-3.0-rc7. I looked into it and I believe I have a fix (line numbers and code refer to 5.x code. Probably the same applies to 6.x)
Replace line 67 in hierarchical_select.js from:
- .find('*').hide().end()
+.find('*').css("display", "none").end()
and problem solved.
Apparently what happens is that collapse.js is executed before hierarchical_select.js, and therefore hides the fieldset div. When hide() is called here on an already hidden element, it does nothing, and therefore once we open the fieldset we see the check box.
Comment #2
wim leersCare to make that into a proper patch? :) Line 67 in HEAD may be different from your line 67. Thanks, bluetegu!
Comment #3
bluetegu commentedAttached please find patches against 5.x-3.x-dev and 6.x-3.x-dev. Not sure whether these are 'proper' patches - if not, let me know what is the procedure I should follow.
Comment #4
wim leersAlmost there! :) This is the proper procedure: http://drupal.org/patch/create. Thanks for going through this effort now, but it'll pay off later (in both Drupal and non-Drupal work), I promise :)
Comment #5
wim leersThanks! Committed!
D6: http://drupal.org/cvs?commit=186256
D5: http://drupal.org/cvs?commit=186258