Download & Extend

Module should not directly manipulate users_roles table

Project:Apply for role
Version:6.x-1.8
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The module should use user_save() or similar mechanism to update the user's roles. Currently it is directly manipulating the database. This means that other modules cannot act on role changes, because they never get notified. Role Change Notify for example, can't send out role change notification messages. Workflow can't take action, etc.

Attached is a patch that uses user_save() to do the change to roles both on approve and deny.

AttachmentSize
user_save_mod.patch1018 bytes

Comments

#1

sweet patch!

#2

Status:needs review» fixed

Thank you!

Applied to -dev.

S.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.