Location Element Validation (Province is not validated) [#351918]

The location fieldset is not really validated at all (at least in my machine, drupal 6). I made it work by making the following changes:

Change line 126 of location.module from:

'#validate' => array('location_element_validate' => array()),

'#element_validate' => array('location_element_validate'),

also change the following block (starting at line 558) (adding the ['#value'], etc.):

    case 'validate':
     if (!empty($obj['country'])) {
        if (!empty($obj['province']) && !empty($obj['province']['#value'])) {
          $provinces = location_get_provinces($obj['country']['#value']);	
          $found = FALSE;
          $p = strtoupper($obj['province']['#value']);
          foreach ($provinces as $k => $v) {
            if ($p == strtoupper($k) || $p == strtoupper($v)) {
              $found = TRUE;
              break;
            }
          }
          if (!$found) {
            form_error($obj['province'], t('The specified province was not found in the specified country.'));
          }
        }
      }

and (line 1550)

function location_element_validate($element, &$form_state) {
  location_invoke_locationapi($element, 'validate'); 
}

Comment	File	Size	Author
#12	location-locationelementvalidation-351918-10.patch	1.67 KB	jerdiggity
#5	province-validation.patch	1.85 KB	aaronbauman

Comments

Comment #1

socialnicheguru commented 30 December 2008 at 13:48

Status:

Active

» Needs review

Will this work on D5? I will see if the same issue is there (with location I am finding that if something is broken on D6 it is usually broken on D5 too).

Changing this to patch code needs review. It isn't in the proper format, but maybe someone who knows more than I can help out so we can make sure this gets into location module.

Thanks again.

Comment #2

yesct commented 15 April 2009 at 13:57

Status:	Needs review	» Needs work
Issue tags:		+location validation

This will get more people reviewing, and maybe committed easier if it is a patch. Check out: http://drupal.org/patch/create and make sure you create the patch against the current dev version. Maybe post a patch against both the D6 and D5 branch.

Also tagging.

Comment #3

summit commented 13 May 2009 at 21:45

Subscribing, greetings, Martijn

Comment #4

aaronbauman

he/him

commented 23 June 2010 at 18:26

You can't just add ['#value'] in locationapi so that it will work with FAPI.
I presume this will break all other implementations of locationapi where it is used.

Comment #5

aaronbauman

he/him

commented 23 June 2010 at 18:45

Status:

Needs work

» Needs review

Status	File	Size
new	province-validation.patch	1.85 KB

Also, the fix above doesn't address the case when "Force default" is enabled for country.

I'm pretty sure this issue is a duplicate, but it's the first one that came up when I searched.

Here's a patch that works for me.

Comment #6

mos2710 commented 3 November 2010 at 18:35

Hi,

Would you be able to do the same for the phone (and possibly fax) validation?

Thanks
Mos2710

Comment #7

arski commented 5 November 2010 at 18:34

Hm, what happens if I don't have the province data for a specific country, but still want to allow the users to enter some values, without validation? At the moment I just get the message that the province is incorrect for the given country :(

Comment #8

marcvangend

he/him

Dutch

Amsterdam

commented 25 May 2012 at 12:53

Version:	6.x-3.0	» 6.x-3.1
Status:	Needs review	» Reviewed & tested by the community

Almost 2 years later, but thanks! The patch in #5 worked for me to enable province validation when the country was set to "force default".

Comment #9

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 1 March 2013 at 19:24

Status:

Reviewed & tested by the community

» Postponed

postponed before tests fix
#1931088: [META] Fixing tests

Comment #10

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 12 March 2013 at 14:38

Version:	6.x-3.1	» 6.x-3.x-dev
Status:	Postponed	» Needs review

tests fixed #1931088: [META] Fixing tests
lets go

Comment #11

12 March 2013 at 14:39

Status:

Needs review

» Needs work

The last submitted patch, province-validation.patch, failed testing.

Comment #12

jerdiggity commented 13 March 2013 at 03:14

Status:

Needs work

» Needs review

Status	File	Size
new	location-locationelementvalidation-351918-10.patch	1.67 KB

Looks like some of this issue was already committed (the first part, regarding line 126) but regardless, submitting patch for the remainder of the list.