Download & Extend
Archive » Issues

Solution to count back a year in 6.x and 5.x

Posted by caomhin on January 1, 2009 at 9:26am
Project:Archive
Version:5.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

This morning I was greeted by an error saying there was an incorrect date on line 106. The following change appears to work:

if($month==1) {
$num_days_prev = cal_days_in_month(CAL_GREGORIAN, 12, $prev_year);
} else {
$num_days_prev = cal_days_in_month(CAL_GREGORIAN, $month-1, $year); // orig code
}
Login or register to post comments

Comments

#1

Posted by ReMedAct on January 1, 2009 at 11:03am

same same:

warning: cal_days_in_month() [function.cal-days-in-month]: invalid date. in /homez.59/my_DB_name/www/sites/all/modules/archive/archive.module on line 106.

I've tried to replace line 106 by your code:

  • at first, issue still here :(
  • second, I clic on the link "function.cal-days-in-month", and error desappear... but come back when clic on another node...

#2

Posted by tithrimimi on January 1, 2009 at 1:58pm

Same issue here but the code appeared to fix the problem.

Thanks.

#3

Posted by sietecoyote on January 1, 2009 at 9:31pm
Title:Can't count back a year» works with 5.14
Version:6.x-1.3» 5.x-1.4

I used your solution with version 5.14 and fixed the warning of cal_days_in_month,,

I just removed the comment in the original code line because leaving it causes a Parse error;
so, my final code is like this:

if($month==1) {
$num_days_prev = cal_days_in_month(CAL_GREGORIAN, 12, $prev_year);
} else {
$num_days_prev = cal_days_in_month(CAL_GREGORIAN, $month-1, $year);
}

#4

Posted by sietecoyote on January 1, 2009 at 9:54pm
Title:works with 5.14» Solution to count back a year in 6.x and 5.x

just fixing the forum title to a better search :)

#5

Posted by sietecoyote on January 1, 2009 at 9:55pm
Version:5.x-1.4» master

just fixing the forum title to a better search :)

#6

Posted by TomChiverton on January 2, 2009 at 2:19am

Same error here on latest 5.x Drupal core and latest version of this module.
Made the change indicated above by hand, and the errors have cleared.

#7

Posted by StS on January 2, 2009 at 11:18am
Status:active» reviewed & tested by the community

The fix is also a possible solution to the same problem with drupal 6.8.

#8

Posted by mdin617 on January 2, 2009 at 8:09pm

A better patch for the 6.x one at least (I don't have 5.x to test with):

// OLD: $num_days_prev = cal_days_in_month(CAL_GREGORIAN, $month-1, $year);
$num_days_prev = cal_days_in_month(CAL_GREGORIAN, $prev_month, $prev_year);

It only requires the one line because the current version of the 6.x branch already works out what last month was and what year it was in and assigns it to the prev_month and prev_year variables.

#9

Posted by pht3k on January 5, 2009 at 12:16am

i tested it on 5.x and it doesn't work for me.(#8)
the other patch is perfect.(#3)
thanks all!

#10

Posted by cssdru on January 4, 2009 at 12:52am

Hello,

I had the same issue but solved now. I tried the mdin617's patch (Drupal 6 too) and it worked perfectly.

Thank you very much!

#11

Posted by tetramentis on January 4, 2009 at 8:52pm

same issue here:

cal_days_in_month() [function.cal-days-in-month]: invalid date. in sites/all/modules/archive/archive.module line 359.

PHP version is 5.2.6-5, Drupal core 5.14, archive module 5.x-1.11.

solution #3 by sietecoyote worked fine, patch file is attached.

AttachmentSize
archive-line-359-error.patch 280 bytes

#12

Posted by bismigalis on February 4, 2009 at 7:32pm

This is more correct fix:

$num_days_prev = cal_days_in_month(CAL_GREGORIAN, $prev_month, $prev_year);

#13

Posted by tetramentis on February 4, 2009 at 7:57pm

according to #9, this one-liner doesn't work on Drupal 5.

#14

Posted by spjsche on January 2, 2010 at 12:12pm

The solution @ #12 did the trick for archive module 6.13

Thanks
Stephen

#15

Posted by binki on January 2, 2010 at 1:31pm

Solution #12 made my day!

Archive 6.x-1.3

Drupal 6.15
MySQL database 5.0.77
PHP 5.2.10
Web server Apache

Thanx!

#16

Posted by tetramentis on January 4, 2010 at 9:03pm

#8/#12 worked for me as well in 6.14 (upgrading to 6.15 right now, but that shouldn't change anything).

Could someone commit this change to the 6.x branch? That would save lots of time for anyone just starting to use the Archive module on 6.x.

And solution in #3 (with patch in #11) seems to work for the 5.x branch, if anyone still needs that.

#17

Posted by spjsche on January 4, 2010 at 11:19pm

+1 for #16

#18

Posted by nektir on January 18, 2010 at 11:04pm

subscribing... please add to next 6.x release

#19

Posted by radiobuzzer on January 20, 2010 at 1:31pm

#12 tested on Drupal 6.15. Fully functional.

#20

Posted by -Shaman- on January 24, 2010 at 2:44pm

Nice module, but doesn't work in January ROFL!

None of the solutions works for me :/

#21

Posted by tetramentis on January 24, 2010 at 5:03pm

#8 (#12) still works fine in January with Drupal 6.15, so Shaman - double-check if you did properly apply the fix and cleared the cache.

#22

Posted by -Shaman- on January 26, 2010 at 2:09am

It's February soon, so I'll wait till next year, perhaps there'll be some update in this module :D

#23

Posted by R.Muilwijk on June 16, 2010 at 6:52pm
Version:master» 5.x-1.x-dev
Status:reviewed & tested by the community» needs work

Fixed for the 6.x branch/7.x-branch. If someone wants this fixed in the 5 version please provide a patch.