If you have an admin theme, the %THEME placeholder for icons makes the editor look into the admin theme for the icons. As a self-respecting Drupal citizen, you are not putting stuff under an existing theme however, so bueditor will not find icons there, and therefore will think that there are no icons, and would anull the icon setting altogether. From there, since your admin page displays in the admin theme, there is no way to set up the icons for the non-admin theme. Not good.

Comments

ufku’s picture

ufku commented
Status: Active » Closed (works as designed)

The purpose of using %THEME is to switch button images when a theme is switched. One should configure the buttons using one of the switchable themes. If there is only single theme option for users of the editor, specifying the path explicitly or using %THEME placeholder are the same.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Closed (works as designed) » Active

As I've said, it looks into the admin theme, and does not allow you to set with %THEME, if you don't have copies of the icons in the admin theme but only on the frontend theme, since it validates the existence of the icons. Is it by design, that you need to have icons in a theme which will never be used on the site, so that it can set it up? I hardly believe.

ufku’s picture

ufku commented

it is by desing that you have to switch to your desired theme or set its path explicitly, e.g. sites/all/themes/example_theme/bueditor_icons

ufku’s picture

ufku commented
Status: Active » Closed (works as designed)

Moreover, %THEME or %FILES placeholders can be used in explicit path declaration,e.g %THEME/../example_theme/icons or %FILES/../themes/example_theme/icons

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Hah, funny. That totally goes against the reason to have %THEME and %FILES at all. Sorry. I understand you don't care about this, so will not keep reopening the issue, but consider this feature useless instead.

ufku’s picture

ufku commented

Do you think there is a solution for this? How should BUEditor resolve %THEME when you're configuring an editor that is assigned to a user role having many theme options. Will that be your(admin's) preferred theme or preferred theme of a random user of that role.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I would not validate the value when the setting is on. Maybe validate that the default theme has that folder, so if the theme in the runtime does not have that folder, the module can fall back on the default theme. As said, validating it with the admin theme requires it to be in the admin theme, even if it is never going to be used, while it does not provide any fallback for the live theme, if it is at the end not in the live theme.

ufku’s picture

ufku commented
Status: Closed (works as designed) » Active

I discovered another bug where %THEME is replaced with bueditor path. It happens inside form theming functions as the global theme_path is temporarily pointed to the bueditor path. Besides fixing this, I implemented a generic approach for paths including %THEME, in which the default theme(as you suggested) is the alternate when an icon or library directory is missing for a specific theme. This should also work for administrator themes.
Sorry, no patch. Changes went directly to the 6.x-1.x branch.

ufku’s picture

ufku commented
Title: Impossible to set up if you have (Garland) admin theme » Impossible to setup using %THEME placeholder
ufku’s picture

ufku commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.