Closed (fixed)
Project:
Hierarchical Select
Version:
6.x-3.x-dev
Component:
Code - Taxonomy
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
5 Jan 2009 at 07:32 UTC
Updated:
3 Apr 2009 at 16:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
sdecabooter commentedI have the same problem.
Before doing an image upload, the HS works perfectly.
After uploading an image, you can still select a value from the first dropdown, but the 2nd dropdown with the children terms is no longer loaded.
In Firefox error console i get the following warnings:
and multiple times
No idea what that's about though... I'll see if i can debug this problem...
Comment #2
Kripsy commentedI can confirm this bug as well. I am guessing the ajax call from the file upload is messing with HS's js.
Comment #3
rapsli commentedis anybody working on this?
Comment #4
Flying Drupalist commentedsubscribe
Comment #5
wim leersrapsli will be sponsoring this patch. Thanks rapsli!
I'll work on this on Monday.
Comment #6
Tschachim1 commentedsubscribing...
Comment #7
FWE commentedsubscribing...
Comment #8
wim leersThis was actually due to a bug in filefield! I've posted a patch in their issue queue: http://drupal.org/node/372401.
I've also managed to make Hierarchical Select more resistant against these kinds of bugs. Almost all of the "compatibility bugs" are actually caused by modules other than HS, so this will probably prevent future problems.
Because I initially thought that the problem was being caused by the fact that HS wasn't using
Drupal.behaviorsyet, I also implemented that.Thanks to rapsli for sponsoring this patch!
Comment #9
wim leersWoops, I attached the Filefield patch instead of the HS patch. Here's the right one. It's already been committed too, of course.
Comment #10
FWE commentedFantastic - Works like a charm!
A sincere thank you for an awesome project and your generosity for providing a solution so quickly - greatly appreciated!
Comment #11
Kripsy commentedI ran into a problem with this patch. I have a required hierarchical taxonomy in a default collapsed field. If the taxonomy is not set and a user tries to save the node, it gives the taxonomy not selected error, but then the hierarchical select's javascript is disabled. This was not an issue with HS before this patch.
Comment #12
wim leersGood catch Kripsy! I've already managed to reproduce it. I'll fix it later today – I've got to leave for school now.
Comment #13
wim leersOk, an update.
My patch in #8, or at least a variation of it, got committed to ImageField.
My changes to hierarchical_select.module, as described here:
actually caused the problem reported by Kripsy. I failed to solve this due to lack of time and so it was reported again yesterday: http://drupal.org/node/408348. gunzip also pretty much posted a patch, so he's credited.
I removed this change that "made HS more resistant against these kinds of bugs". And all is good now, because ImageField itself was fixed.
Commit: http://drupal.org/cvs?commit=186202.