Closed (fixed)
Project:
User Points
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Jan 2009 at 15:08 UTC
Updated:
16 Aug 2010 at 17:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
kbahey commentedNeed a properly formatted, working and tested patch as per http://drupal.org/patch
Comment #2
jredding commentedor at the very least be more specific. Which page did you see these on?
Comment #3
tlogan commentedHeh... I was just about to post a similar issue with a small patch to fix the 1 missing ! that I encountered. After seeing this, I went back and found several more. This is the first patch I've created so if I did something wrong, a little gentle correction would be appreciated.
Comment #4
kbahey commentedThank you! That is more like it.
Committed to 6.x-1.x-dev and should be available in a few hours in the tarball.
Comment #5
FrankT commentedThanks so far, this strings is left containing a
<br/>:If you have used userpoints_basic prior to v3 you may need to enable this fix.<br/>[...](at least two times within this longer string)The are also still strings left containing hard coded 'points':
Points accumulated by users on your site.The number of points to awardOut of a maximum pointsPoints accumulated by users on your site.A User's current points.Grant points to a userNumber of pointsCurrent PointsIm not sure about the string 'Points' itself. Also about the string '!Points' (with singular and plural) and !points: is is the default value for the user defined branding of 'Points'?
Unsure about
Word to use in the interface for the upper case plural word !PointsandWord to use in the interface for the lower case plural word !points, too.Shouldn't the string 'Approve Userpoints' be changed, too, to allow the use of !points?
Comment #6
jredding commentedComment #7
FrankT commentedChecked against todays (surprising) V6.x-1.0 but it is not fixed, neither the br-trag nor the strings containing hard coded 'points'.
Comment #8
FrankT commentedI also found out that on page ?q=admin/user/userpoints/add there are !Points appearing instead of the value that it represents (it refers to my translated interface, but on other pages it worked). If you want it as a separate issue, please let me know.
Comment #9
kbahey commentedFixes never go in stable releases. They go to the -dev version.
Check that version.
Comment #10
jredding commentedI just checked against dev and stable and both of this are fixed.
Please be more specific with you bug reports.
What line number are you seeing this on because a search for these strings does not render a positive result.
Comment #11
FrankT commentedI applied todays dev version first. Then I extracted userpoints_basic including the translations. On line 51 (as poedit says) there is a string
The first and second line and the line before 1) contain a (so at least 3 occurences).
I made some random tests on the strings mentioned in #5 (http://drupal.org/node/355042#comment-1189087) but they seem to be unchanged, too. But I suggest to concentrate on the
<br/>first.With the latest dev a new string with a hard coded 'points' instead of !points was introduced:
Select which category of points to display on the user profile page. Select \"All\" to display a sum total of all categoriesComment #12
jredding commentedI am not sure where you are downloading userpoints but it is not from drupal.org. Stable version 6.x and DEV Version 6.x no longer contain userpoints_basic.
Please verify your download location and that you are looking at the latest version of either DEV or Stable version 6.
Comment #13
jredding commentedhhmm.. well you are getting part of the latest dev since that is a new string.
Its very confusing as to how you are seeing userpoints_basic though so that no longer exists.
Comment #14
FrankT commentedBased on your last comment I decided to completely remove the module (disable, uninstall, delete the directory) and then reinstalled the module. After that there is no more userpoints_basic module. I cannot reproduce it and I don't know with which version of userpoints I started (but definitively V6.x), but it looks like some update problem.
I updated my translation file and can confirm that there is no
<br/>any more.Now in this issue we can concentrate on hard coded 'Points'
Currently I see the strings
Points accumulated by users on your site.Out of a maximum pointsPoints brandingThe number of points to awardPoints accumulated by users on your site.PointsA User's current points.Im not sure about the string 'Points' itself. Also about the string '!Points' (with singular and plural) and !points: is is the default value for the user defined branding of 'Points'?
Shouldn't the string
Approve Userpointsbe changed, too, to allow the use of !points?On the other side there still is the problem mentioned in #8 (I can still create a spearate issue for that).
Comment #15
jredding commentedGood I'm glad that we got the issue taken care of.
To make things easier for module maintainers please post the files as well as line number that you found these strings. They are listed when you use poedit (or whichever application you are using). In either case I searched for these and fixed them as necessary. A few of them are left as "Points" because they are admin facing strings and make the most sense as staying as "Points". For example "Points Branding" shouldn't be changed as it accurately describes what you are doing branding or rebranding the original item that is "points".
I also found a few other strings that weren't properly ran through userpoints_translation(), they have been fixed.
I'm confused by this statement, please clarify.
Yes and it has been fixed. This page used to be a "hidden" page until a confirmation was added because of this it slipped through the t() radar.
fixed
Comment #16
FrankT commentedThanks, sounds great. I will check it as soon as possible (and after the new dev is available). As my holidays are ending today it could take some days.
Comment #17
FrankT commentedThe following strings are left with a hard coded 'point':
Points brandingI guess it is intended as the main place where the branding happens. I can agree.Points???Number of PointsCurrent PointsUsers earn points as they post nodes, comments, and vote on nodes.I think it could remain like that.There is a special thing about a translatable string
!pointsand!Points(so I come back to your request for further information on that). I also should add that I cannot read much in the programming code itself, that's why I need to ask.I always understood !points as kind of a variable, the value of which is being entered as 'points branding'. So I currently do not know how to handle it.
- Is it the initial setting of the translated word for points?
- Or is it just a variable and therefore should not be translatable?
- or is it a possibility to translate !points as !Points if needed?
- etc.?
Comment #18
jredding commentedSome of the points have to remain as points, the module after all is called userpoints. If we changed every "points" to whatever was in branding it would become confusing. Or in short, the four "untranslated" strings you placed here will remain untranslated.
Points branding is meant as a quick and easy way to change the word points into a new brand for your website. It is not intended for wholesale translation of a website. You will need to use the locale module for that (or any of the i18n or l10n modules).
In regards to your questions. !Point, !points, !point are all variables according to what is in points branding.
so t("You have earned 5 !points", userpoints_translation())
would translate !points to whatever is in branding for example
"You have earned 5 brownies".
Comment #19
berdirLooks like everything here has been addressed, so let's close this issue. Note that the branding feature currently doesn't work together with translations, see #791734: Translation of Branded Points.