The 4.6 tar ball for this module contains a folder named 4.5.2 which includes a taxonomy.access module and a taxonomy.patch. Very thoughtful.
However, it also contains another taxonomy.patch in the main folder, along with the .module and sql files. The README.txt says:
taxonomy.patch is a patch for 4.5.0 of taxonomy.module that makes sure users don't see or update to categories if they don't have the proper access.
Step 3 of the INSTALL.txt says:
3) Patch taxonomy.module with the included taxonomy.patch with the command 'patch -p0 < taxonomy.patch' while in your drupal installation's module directory.
I am left wondering if it is necessary to actually patch the taxonomy.module (but the readme only mentions 4.5). If not, why is the taxonomy.patch there for the 4.6 version?
I am using 4.6.3
Any suggestions?
Comments
i cant understad
I ran in same problem ramdak5000.
Same discussion also in this topic:
http://drupal.org/node/22124
I cant understad the term "Patch with the command". I really have no clue about Linux based OS and i preffer windows only because it has the best support for third party software.
Drupal seems to function properly on windows... So, why not make the installing guides for everykind of people.
For example.. some people dont have that kind of direct access to their (mostly hosted) server, to "Patch with the command" from somekind of console.
So, please.. can someone explain how do i modify the taxonomy.module manually. Where to add, where to modify the lines ?
PS: I have now read many posts on these forums, where the developers suggest ppl to learn how to develope.. learn unix, cvs.. bla bla bla... and complaining like "why is this not made simple, like drupal should be?" by the "newbie" users.
All i can say to developers is.. Is this really so hard, to patch the module in a test server (with the newest core), then add it to the module installation file with the original module, so it would be easy to undo the changes (many newbies dont realise to make copyes).
For exaple see " signature.module (tested with Drupal 4.6.2) " I bet, that eaven unix-linux-mac... users would be happy.
At the moment all i need, is a patched taxonomy.module for the core 4.6.3. Could someone do this and upluad this file and post a link here ? Please.
There are pages. Several.
step 3 is the command you need. It is all you need if you have the tools.
Using diff and patch is not a Drupal thing. This is a general development tools thing. There are many resources on the web on how to do this. The are several pages in the handbook Diff and Patch on tools you can use in a Windows environment. You need to get the tools to do this.
I suggest the Gnuwin32 tools as they work and don't require an entire environment.
There is even a detailed guide for using a cygwin environment on your Windows system.
Step 3 is exactly the command you need.
Here is a link to the patch man page I found with Google.
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
There shouldn't be patches
There shouldn't be patches in the first place. Current "best practice" software development is to roll patches into releases and bump the rev number. This shouldn't be too hard to do. Drupal already provides a pretty good CVS system.
It's easy actually...without patches, one doesn't need tools. How refreshing.
the necessary changes for
the necessary changes for this module to work are not partof Drupal core. Drupal 4.6.x is feature frozen. These features will not be added to Drupal 4.6 taxonomy module in core.
In order to use this module, you have to modify a Drupal core module. You may supply a module that does not require a modification to Drupal core if you like that will prevent the need for patching files.
Your contributions will be welcome. Please join the Drupal developers list and contribute work towards helping see that this happens.
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
OK
OK, I understand what you are saying. However, user patches are still unnecessary. The the module should be providing is:
1. Adequate documentation
2. Modified (patched) module
3. Modified (patched) core modules
4. Adequate revision tracking
Believe me, I am not inventing this. Every software company in which I have worked has established these practices (and then some).
Part of the problem is module revisioning. I have 5 or 6 modules that have been updated (patched) over the last few months and I went back and looked and the patched modules have the same revision number as the non-patched module. This really makes life difficult.
At any rate, I'm certainly glad to help.
sepeck, i think you did not
sepeck, i think you did not understand me... try to read my reply entirely...
You suggest me to install somekind of software as i see. This surely can fix the problem if i would have my own server. But if i have a host, then what ? All i have is FTP access and ControlPanel. I can not execute any exe. files... And this is only ONE possibility of not being able to "Patch with the command".
I will quote myself now:"Is this really so hard, to patch the module in a test server (with the newest core), then add it to the module installation file with the unpatched module, so it would be easy to undo the changes (many newbies dont realise to make copyes)....At the moment all i need, is a patched taxonomy.module for the core 4.6.3. Could someone do this and upluad this file and post a link here ? Please."
sigh... I did read it
Install the tools of your choice on your local computer I strongly suggest the Gnuwin32 tools.
Download the Drupal files in quesiton to your local Windows PC.
Download the patch in question to the same directory on your windows PC.
RUN the patch command on your LOCAL windows pc to patch the file in question.
FTP the patched file to your server.
Make a note somewhere that you have a patched file on your server so that when a Drupal upgrade is available, you will be sure not to inadvertantly overwrite your modified file and lose functionality.
To answer your bold words, yes and no. The fact that it is not done is a strong answer in and of itself. Once you learn how to do this, then you will be in a better position to contribute back to this project.
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
Have you really never heard
Have you really never heard of remote hosting companies ?... I shut down my LOCAL pc every night. My local PC does not have enough good bandwith... etc. Thats why i use a WEBHOST... so you need to call it REMOTE, not local PC.
Here, ...
Webhosts:
http://www.webhosting.info/webhosts/
http://www.top10webhosting.com/
Free webhosting
www.freewebspace.net
www.free-webhosts.com
www.webhosts4free.com
Webhost talk, to discuss about them
http://www.webhostingtalk.com/
If you did read my post, the try overreading it please...
I will quote the very important part now...
"For example.. some people dont have that kind of direct access to their (mostly hosted) server, to "Patch with the command" from somekind of console."
So there is no way for me to patch it. And i know it is very complicated to write a help file how to manually patch the core modules. The only solution i see is in the STRONG format in my last reply named "sepeck, i think you did not"
Ok the topic should now be closed... My request has been answered. Thank you very very much for understaning shouchen.
For other ppl, who cant "patch" the taxonomy.module hit the link below:
http://drupal.org/node/37061
And damn i have to link some topics here.. the discussion is about the same issue... taxonomy.module patching.
http://drupal.org/node/22124
http://drupal.org/node/36967
There is no need for a rude tone...
What sepeck said was perfectly correct. You can indeed patch files from your own (Windows) computer using either Cygwin or GnuWin32 tools, and then simply upload the changed files to your web host via FTP. The pages he referred to detail how to do this. There is no need to be condescending and rude.
Just wanted to clarify this for someone else using Windows who may come along and think they can't patch files themselves. Though it's a bit to wrap your head around at first, once you learn how diffing and patching works, you're now in a much better position to try out new features of Drupal and contrib modules, as well as contribute back improvements that you've made.
Misunderstanding?
You seem to have misunderstood sepeck. He did not suggest running Drupal on your local computer (I can understand that to be a problem), but only to temporarily copy the Drupal software to your local computer, then patch it, and afterwards copy it back to your hosting service. So you would continue using your hosting service as the place Drupal runs from, and just use your local computer for the applying of the patch.
Have fun,
Frodo
this is fast becoming not worth it
The steps I supplied are the EXACT steps I use with one exception, I don't use FTP to transfer files I use SCP.
I am unsure how much more detailed that I can be with the instructions that will make it clear for you.
You stated you had FTP access to your host.
You are obviously unfamiler with Drupal development and release. I answered ramdak500 here with information relavant to the whys of this. It is very important that you understand how and what you did to your site. This is because you need to be able to maintain it, update it and be aware of any security implications of modifying core modules.
I am not doing this to spite you, I am trying to help you learn how to use the tools to more successfully accomplish what you want to do.
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
Sorry
Sorry for the rude tone...
It came from your answer to me.
Firstly i asked how to patch the file, if cant patch it. I didnt think of running a local webserver. And as one module (signature.module) had all the neccesary files in the installation, then it made me mad that taxonomy.access had somekind of patch wich i could not use.
And then sepeck just ignored all my questions. In his answer he told me to get the software and to get familiar with the "patching" thing. Although i explained my situation.
If you would have suggested me the idea to patch the files on my local PC, and then update the remote ones at the firs place, i wouldnt have suggested, that you didnt read my post.
I didnt think out of box. Sorry. I will then get familiar with the Apache and MySQL again... long time no see with these pals.
As one last follow up, I
As one last follow up, I don't run MySQL or Apache on my local system. All you need are the source files and the patch and diff tools. You are manipulating files not running the website locally.
Running the website locally can help you play with and experiment with testing new things but is not necessary for patching. It can provide a nice place to test your backups, to expriment with upgrades and various other configurations.
As a clarification, I did not ignore your question, I tried to provide you with the links to the information and tools to allow you to accomplish this yourself. Some of these links are the very links I used to learn how to do this myself (not with this module but test other patches). Others are links I added to the handbook to help ease usage on Windows.
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
Ok i tryed that GnuWin32...
Ok i tryed that GnuWin32... and i cant understand it.
http://drupal.org/node/32635
What does he mean with
"If you add the bin directory"
In this location there already is a folder named bin.
I tryed running the command with cmd and it didnt recognize the patch commant.
Also tried to understand this:
http://gnuwin32.sourceforge.net/install.html
The whole guide there is confusing. All i can understand is that i have to install it, well this is done. And then about the usage is that its someting to do with command.com and cmd.exe.
Is there any other simple step to step tutorials about this ?
Iv done with the local server. There are excellent guides about how to set up a WAMP (windows-apache-mysql-php).
if you are going to quote
then you need to quote the entire part including the important parts
-sp
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain
-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide
Not very many answers from
Not very many answers from google.
http://www.google.com/search?hl=en&lr=&q=%22Windows+how+to+site%22&btnG=...
Well, i finally got it
Well, i finally got it working.
All i actually needed was patch.exe and to manually make a patch.bat in windows dir. Then make it open .patch files by default.
And guess what... it didnt manage to patch the damn file !...
I then downloaded tortoise CVS, and made patch files, then tryed these and they all worked, so i my installation should be working.
Finally i got myself notepad2 ... it highlighst the - and + lines in .patch files and some more in other codes. And i patched the file manually. Added all the + lines and replaced all the - lines. And it actually worked !