nodeorder.install success message issue

gunspae - January 8, 2009 - 01:17
Project:nodeorder
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:installation
Description

Installation/uninstallation of nodeorder reports failure, regardless of actual success or failure.

Problem is that drupal_add_field() and drupal_drop_field() return nested arrays, while the installation functions expect a single flat array.

ie: instead of

if ($ret['success'] === TRUE) { ... }

it should go something like

if ($ret[$i]['success'] === TRUE) { ... }

where $i is an integer. The attached patch iterates through the nested arrays and checks for error values.

AttachmentSize
nodeorder.install.fixed_success_checks.patch2.53 KB

#1

pvanderspek - January 8, 2009 - 18:31
Status:needs review» reviewed & tested by the community

Patch commited and will show up in the next new dev release.

#2

pvanderspek - February 6, 2009 - 12:30
Status:reviewed & tested by the community» fixed

#3

System Message - February 20, 2009 - 12:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.