The function checks for !== FALSE, when array() is also a negative result for the xpath check. See attached patch.

CommentFileSizeAuthor
#4 simpletest.assert-title.patch2.14 KBlyricnz
#1 simpletest-assert-title.patch772 bytesjpetso
simpletest-assert-title.patch511 byteslyricnz

Comments

jpetso’s picture

jpetso commented
StatusFileSize
new simpletest-assert-title.patch772 bytes

In Drupal 7, this is already changed - but to assertTrue() instead of !empty(), which is really the same thing written differently. I suggest doing it the same way in the D6 version of SimpleTest as well. Patch attached, code shamelessly stolen from core.

lyricnz’s picture

lyricnz commented
Status: Needs review » Reviewed & tested by the community

Ok

lyricnz’s picture

lyricnz commented
Status: Reviewed & tested by the community » Needs work

Actually, we should probably backport all of the D7 patch, which comes from http://drupal.org/node/345632#comment-1149863

lyricnz’s picture

lyricnz commented
Status: Needs work » Needs review
StatusFileSize
new simpletest.assert-title.patch2.14 KB

Reroll patch from #345632: SimpleTest: correct assertTitle logic for simpletest 6.x-2 branch.

chx’s picture

chx commented
Status: Needs review » Fixed
boombatower’s picture

boombatower commented

Complete backport of Drupal 7.x SimpleTest module. (voids all backports). (SimpleTest 2.6)

Please re-open if still an issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.