reset/set default text size

This was considered in the original building of the module, but we thought it destroyed the visual simplicity of the module. My recommendation is to set your minimum font size equal to your default font size. The jQuery script within the module is set so that it will eventually take the user back to that base font size.

So if you increase the font, then decrease a few times, you'll eventually be back at your default font size. This is more or less equivalent to the reset button you're asking for.

IMHO almost identical third button will not affect visual simplicity at all and let users keep ability to decrease font size, which is quite important. Maybe you can consider adding this as an admin-selectable option?

We've had a lot of people asking for this in different issues, so I'll take a look at the best way to implement this.

Just added the reset button capability into the dev version. Please let me know if you get a chance to test this. You need to visit the module's admin/settings/text_resize page to enable the button. It is disabled by default.

This is a much needed feature, but unfortunately the 1.5 release is broken. In fact, the "reset" sets the font to minimum, rather than normal. A quick look into JS code revealed that to be exactly the logic. I rolled a patch that properly clears the settings. Please review and commit!

Please don't place directives such as "please review and commit" in the issue queue. This approach doesn't help to make a case for the change you're suggesting.

I do not have time to argue. Here is the fix, you can take it from here as you wish. Thanks.

The above patch assumes that the site administrator can and will set the minimum size to a size that is smaller than the default size which, in my opinion, is a bad/unnecessary usability practice.

As an alternative, I've updated the text on the admin screen to point out the fact that the reset button resets to the minimum/default size if enabled.

This behavior does not make sense and is not intuitive to end user. If I am end user seeing buttons to increase, decrease and reset, my expectation is reset button will return the font size to where it started. End users would not read your documentation, they need to be guided by three little buttons.

Please take a look at how my patch solves the problem. At least this behavior should be made an option.

Not done. Reset needs to restore the size back to what it was, not the minimum.

Thanks for a much-needed module. Although I haven't yet re-installed/tested the latest version, I'd also like to suggest that the Reset button return to the starting, not minimum, font size. As a developer I don't always (in fact, almost never) set the base font tiny, even though some will prefer that setting. I set it to an optimum size for the page layout and content I am displaying, so that I can be sure the first impression is exactly as I want it to be "above the fold" upon page load. I have one second to entice the visitor to stay ... for many people (particularly older ones), if the font size loads very small and they don't notice the text resizing option, they'll click out and I've lost them. My style (which you are free to call "bad/unnecessary," but is my style nonetheless) is to go more middle of the road and allow the site visitor to adjust up or down according to her/his display, eyesight, etc. For some people that will certainly mean reducing from the size that opened. So, I feel the Reset button should not assume original size = minimum size. IMO an easy return to whatever the starting point was is not only better for accessibility, but also the more intuitive behavior of a Reset.

Thanks - hope you'll consider this perspective.

@m.e.: Try my patch above, works great for me. I just hope it would get merged back into the module to reduce maintenance headache.

@dkruglyak: may do that, thanks. There's an issue with my theme that will be a deal-breaker, so I need to see that solved before putting any more effort into upgrades/patches. I'm surprised there is only this one module to choose from - font accessibility would be popular enough to support many kinds of solutions, I would think.

@m.e.: This seems to be tricky for most themes. You just need to find the right DOM element to manipulate, once you find it then it is easy.

I have seen another similar module (forgot what it is called), but it is broken even worse than this one.

Although dkruglyak's tone does not seem conducive towards collaboration, I agree with his feature preference of reset = default, and decrease to be able to be smaller, rather than minimum = default. Not that smaller than default would be commonly used, but the 3 buttons would then be more intuitive. It also might help to have a title attribute on at least "reset".

+1 on dkruglyak's idea...

I also agree that reset should go to the default size, not the minimum. I'm going to remove the button, as it will be too confusing for end users who are already not very web savvy (hence the need for the button instead of people just using the View menu on their browser).