reset/set default text size

This was considered in the original building of the module, but we thought it destroyed the visual simplicity of the module. My recommendation is to set your minimum font size equal to your default font size. The jQuery script within the module is set so that it will eventually take the user back to that base font size.

So if you increase the font, then decrease a few times, you'll eventually be back at your default font size. This is more or less equivalent to the reset button you're asking for.

We've had a lot of people asking for this in different issues, so I'll take a look at the best way to implement this.

Just added the reset button capability into the dev version. Please let me know if you get a chance to test this. You need to visit the module's admin/settings/text_resize page to enable the button. It is disabled by default.

This is a much needed feature, but unfortunately the 1.5 release is broken. In fact, the "reset" sets the font to minimum, rather than normal. A quick look into JS code revealed that to be exactly the logic. I rolled a patch that properly clears the settings. Please review and commit!

Please don't place directives such as "please review and commit" in the issue queue. This approach doesn't help to make a case for the change you're suggesting.

I do not have time to argue. Here is the fix, you can take it from here as you wish. Thanks.

The above patch assumes that the site administrator can and will set the minimum size to a size that is smaller than the default size which, in my opinion, is a bad/unnecessary usability practice.

As an alternative, I've updated the text on the admin screen to point out the fact that the reset button resets to the minimum/default size if enabled.

This behavior does not make sense and is not intuitive to end user. If I am end user seeing buttons to increase, decrease and reset, my expectation is reset button will return the font size to where it started. End users would not read your documentation, they need to be guided by three little buttons.

Please take a look at how my patch solves the problem. At least this behavior should be made an option.

Not done. Reset needs to restore the size back to what it was, not the minimum.

Thanks for a much-needed module. Although I haven't yet re-installed/tested the latest version, I'd also like to suggest that the Reset button return to the starting, not minimum, font size. As a developer I don't always (in fact, almost never) set the base font tiny, even though some will prefer that setting. I set it to an optimum size for the page layout and content I am displaying, so that I can be sure the first impression is exactly as I want it to be "above the fold" upon page load. I have one second to entice the visitor to stay ... for many people (particularly older ones), if the font size loads very small and they don't notice the text resizing option, they'll click out and I've lost them. My style (which you are free to call "bad/unnecessary," but is my style nonetheless) is to go more middle of the road and allow the site visitor to adjust up or down according to her/his display, eyesight, etc. For some people that will certainly mean reducing from the size that opened. So, I feel the Reset button should not assume original size = minimum size. IMO an easy return to whatever the starting point was is not only better for accessibility, but also the more intuitive behavior of a Reset.

Thanks - hope you'll consider this perspective.

@m.e.: Try my patch above, works great for me. I just hope it would get merged back into the module to reduce maintenance headache.

@dkruglyak: may do that, thanks. There's an issue with my theme that will be a deal-breaker, so I need to see that solved before putting any more effort into upgrades/patches. I'm surprised there is only this one module to choose from - font accessibility would be popular enough to support many kinds of solutions, I would think.

@m.e.: This seems to be tricky for most themes. You just need to find the right DOM element to manipulate, once you find it then it is easy.

I have seen another similar module (forgot what it is called), but it is broken even worse than this one.

Although dkruglyak's tone does not seem conducive towards collaboration, I agree with his feature preference of reset = default, and decrease to be able to be smaller, rather than minimum = default. Not that smaller than default would be commonly used, but the 3 buttons would then be more intuitive. It also might help to have a title attribute on at least "reset".

+1 on dkruglyak's idea...

I also agree that reset should go to the default size, not the minimum. I'm going to remove the button, as it will be too confusing for end users who are already not very web savvy (hence the need for the button instead of people just using the View menu on their browser).

#5 works perfectly. Thanks dkruglyak!

I understand that the author doesn't want people to set the font smaller than the default, but I want to initially have a font that targets the bulk of my target audience... and if someone wants to go smaller and others larger, so be it. But being able to find that middle ground in a click is way awesome.

I understand the author doesn't want that, and that's fine... but the patch works. So anyone wanting it that way, you can easily implement.

Thanks for the patch.

I am using this module on a system with dozens of different unrelated themes, all with independent default font sizes, so enforcing the 'reset' button to change to the minimum does not work in my case.

If it really is a "Reset" button, shouldn't it "undo" what it did? Inspecting DOM shows font-size tags remaining everywhere after reset..

Hi all,

Sorry to be a a pain to the group but I am one of those user / administrators who is just good enough to be dangerous. LOL I have been ask by my boss to try and implement something like this our website. I have been following the thread and think this will work for us but my problem is this...

Could some one tell me if I have done this right, it does not appear to work on my site... but it may not from others have said.

BTW the site is www.daybreakps.com it is very much a work in progress.

But I have replace the code in the text sizer js with the code form the downloaded patch file and re uploaded to the site. Was or is that the correct process?

Thanks for all the help and advice!

Moe

@n4cqw You'll need to open a support request for your question since it's not related to this discussion.

I would like to add my support for including the patch from #5 in the next version of this module. I agree with the others who have posted that some users may actually want to use a smaller font size than the default, and therefore the reset button should return the site to the default size, not the minimum size.

@attheshow, thanks for a valuable module! I understand your usability concern, but you can see from the replies that not everyone agrees. May I suggest that you allow the site builder to decide the appropriate behavior for his/her site. With the patch in #5, the site builder can still decide to set the default and minimum font sizes to be the same size, but also has the freedom to choose a different behavior.

Thank you.

subscribing. one more vote here for disentangling default from minimum.

Patch to fix reset button to actually reset.
Patch is against 1.6 stable.

Some of the changes are just formatting for the sake of readability.

This should probably be closed.. Unless there's a fix for D7 or D8...