I'm aware of previous bug reports relating to swf_update and flash 10.

http://drupal.org/node/351643 - upload problem
http://drupal.org/node/355079 - problem with batch images upload

This appears to be a different issue, so I'm opening a new bug report. I'm using Flash 10,0,12,36, and this issue can consistently be reproduced in either Firefox or IE.

swf upload hangs after the first image if invoked from the "Photos Management" tab of an album. The URL is '/node/##/photos'. Batch upload works reliably when invoked from the "Album photos" >> "Upload image" link in the Navigation menu. The URL is "/photos/upload".

There are two attached screenshots illustrating the problem.

Snippet that doesn't work - the upload_url has the node:

var swfu; window.onload = function() { var settings = { flash_url : "/sites/all/modules/photos/simpledemo/swfupload.swf", upload_url: "/photos_swfu/upload_node/66?uid=4dd4652fd862c9e0f64daf4c7cac75b0", post_params: {"PHPSESSID" : "4dd4652fd862c9e0f64daf4c7cac75b0"}, Snippet that works doesn't have that: var swfu; window.onload = function() { var settings = { flash_url : "/sites/all/modules/photos/simpledemo/swfupload.swf", upload_url: "/photos_swfu/upload?uid=4dd4652fd862c9e0f64daf4c7cac75b0", post_params: {"PHPSESSID" : "4dd4652fd862c9e0f64daf4c7cac75b0"}, I believe this is related to the fact that the upload process always ends in the "/photos/upload" page. It works ok when the upload starts there, but doesn't work when started from the album page "/node/##/photos".
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

worldwidemv’s picture

Status: Active » Needs work

Thank you for stearing me in the right direction.

The problem is a missing return true; on the end of function photos_swfu_node($node)
(file photos_sfwu.php)

As a result, the status "complet" is never triggert.

Sorry for not provieding a real patch.

chakrax’s picture

Thanks for reviewing the bug report.

I added the return true; statement after line 271 of photos_swfu.module, and now it works!. I'm not sure how to roll this into an official patch - but I can verify that the solution works.

jaypabs’s picture

Version: 6.x-1.4-beta3 » 6.x-2.5-beta4

Yes it works for version 6.x-2.5-beta4.

Thanks

vesapalmu’s picture

Status: Needs work » Needs review
FileSize
506 bytes

Here's the patch

radiofranky2009’s picture

thanks. The "return = true" fixed the problem.

yogeshchaugule8’s picture

Thanks. the patch works for me also.

Thanks Again

vesapalmu’s picture

Status: Needs review » Fixed

So this is fixed then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.