Closed (fixed)
Project:
Project
Version:
6.x-1.x-dev
Component:
Releases
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
13 Jan 2009 at 00:07 UTC
Updated:
13 Feb 2009 at 04:20 UTC
Jump to comment: Most recent file
If you preview or save a release node right now in HEAD, there are a bunch of problems:
A) All kinds of PHP warnings from project_release_exists()
B) The version numbers you typed in are in fact gone after you preview.
C) The title isn't saved
D) File uploading is broken (should probably not even fix this and just work on #179471: release file attachments should use drupal upload functionality instead).
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 357920-11.file_get_mimetype.patch | 1.58 KB | dww |
| #8 | 357920-8.project_release_nodes.patch | 9.35 KB | dww |
| #6 | project_release_preview.patch | 17.88 KB | hunmonk |
| #4 | project_release_file_handling.patch | 28.44 KB | hunmonk |
| #2 | project_release_file_handling.patch | 28.44 KB | hunmonk |
Comments
Comment #1
dwwCommitted a fix for (A).
Working on (B) and (C) now.
Comment #2
hunmonk commentedattached patch fixes up the basic file handling, and paves the way for multiple files per release node.
Comment #3
dww- Changes to project_release.install (which Chad's already got).
- Can't attach files to new release nodes, only while editing.
Will look at the rest of this when the above is fixed.
Comment #4
hunmonk commentedk, those are fixed.
Comment #5
dwwChad committed that to HEAD. Back to active for (B), (C), and the fact that validation doesn't appear to be working right -- e.g. required fields are not actually required, etc.
Comment #6
hunmonk commentedhere's another patch that fixes previews.
Comment #7
dwwWe committed #6. However, there's still something broken with setting the version string (and therefore, the title of the node) when you submit. I'm working on this part.
Comment #8
dwwMost of #7 was seriously broken by #98278: project* namespace bugs in $node and confusion about what kind of arguments project_release_get_version() expected. Fixed all that and added comments to hopefully prevent future bugs. Fixed some other problems, too.
2 known bugs:
A) If you edit an existing release node as an admin and try to change the title or version string, the new form values are never displayed on preview or saved to the DB on submit.
B) If you add a new release for a given API compatibility term and major version, the release download table on the project node doesn't seem to get rebuilt with the newer version.
Comment #9
dwwCommitted #8, working on the known bugs now.
Comment #10
dww(B) Phew -- is due to #366163: {project_release_nodes} created with faulty data, not a bug in the code. ;)
Working on (A) now.
Comment #11
dwwWhile working on #366448: Port packaging script to new {project_release_file} schema I discovered file_get_mimetype. ;) We should use that in this DB update.
Comment #12
dwwI've fixed all this now and committed everything to HEAD.