The project_release_by_project view from #357926: Port project_release to views2 which is how #94138: RSS feeds for release nodes works in D6 has a breadcrumb that just leads back to "Home". In D5, the breadcrumb on this page leads you back to the project, like so: "Home » Download » Modules » Project". The latter is preferable. Not sure if/how to set breadcrumbs for views.

Comments

dww’s picture

Issue tags: +drupal.org upgrade

#378748: Missing breadcrumb on project releases page marked dup. Adding tag to make this more visible.

dww’s picture

Assigned: Unassigned » dww

Earl and I got together tonight to figure out some of my remaining views-related questions. I now know how to solve this. What we want is to extend the node_nid argument handler as project_handler_argument_project_nid, and all set_breadcrumb() in that argument handler. We probably want an option for the argument handler that decides if the breadcrumb should include the project itself or not, e.g. for node/% vs. node/%/foo (where you want the breadcrumb to include the specific project itself). Should be pretty straight-forward. I'll work on this ASAP.

hass’s picture

fuzzy_texan’s picture

marcp’s picture

This is minor but also a 6.x-1.0 blocker. Doesn't seem like a breadcrumb issue should block a 6.x release.

dww’s picture

Priority: Minor » Normal
Issue tags: +drupal.org redesign, +drupal.org redesign project

drumm would like this fixed for the redesign. Tagging and bumping priority.

dww’s picture

Status: Active » Needs review
StatusFileSize
new5.78 KB

This patch adds the breadcrumb:

http://scratch.drupal.org/node/3281/release

However, for some reason, this isn't triggering the navigation magic on redesign.d.o:

http://redesign.drupal.org/node/3281/release

Even though the patch is applied, views cache cleared, etc.

drumm’s picture

Committed what was needed to get to the right section to drupalorg. Now the section header and tabs are correct. The breadcrumb here should fill in the rest, highlighting the appropriate tab and a link back to the project.

dww’s picture

Status: Needs review » Fixed

Committed #7 to Project HEAD, imported into bzr vendor, merged into drupal.org branch, and deployed:

http://drupal.org/node/3281/release

drumm's fixes for drupalorg_crossite are now live on redesign:

http://redesign.drupal.org/node/3281/release

Calling this done.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org upgrade, -drupal.org redesign, -6.x-1.0 blocker, -drupal.org redesign project

Automatically closed -- issue fixed for 2 weeks with no activity.