The project_release_by_project view from #357926: Port project_release to views2 which is how #94138: RSS feeds for release nodes works in D6 has a breadcrumb that just leads back to "Home". In D5, the breadcrumb on this page leads you back to the project, like so: "Home » Download » Modules » Project". The latter is preferable. Not sure if/how to set breadcrumbs for views.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 358563-7.project-release-view-breadcrumb.patch | 5.78 KB | dww |
Comments
Comment #1
dww#378748: Missing breadcrumb on project releases page marked dup. Adding tag to make this more visible.
Comment #2
dwwEarl and I got together tonight to figure out some of my remaining views-related questions. I now know how to solve this. What we want is to extend the node_nid argument handler as project_handler_argument_project_nid, and all set_breadcrumb() in that argument handler. We probably want an option for the argument handler that decides if the breadcrumb should include the project itself or not, e.g. for node/% vs. node/%/foo (where you want the breadcrumb to include the specific project itself). Should be pretty straight-forward. I'll work on this ASAP.
Comment #3
hass commentedsub, #420910: Breadcrumb incomplete on project releases page marked as dup
Comment #4
fuzzy_texan commentedTagging for #439958: Document issues left before 6.x official release
Comment #5
marcp commentedThis is minor but also a 6.x-1.0 blocker. Doesn't seem like a breadcrumb issue should block a 6.x release.
Comment #6
dwwdrumm would like this fixed for the redesign. Tagging and bumping priority.
Comment #7
dwwThis patch adds the breadcrumb:
http://scratch.drupal.org/node/3281/release
However, for some reason, this isn't triggering the navigation magic on redesign.d.o:
http://redesign.drupal.org/node/3281/release
Even though the patch is applied, views cache cleared, etc.
Comment #8
drummCommitted what was needed to get to the right section to drupalorg. Now the section header and tabs are correct. The breadcrumb here should fill in the rest, highlighting the appropriate tab and a link back to the project.
Comment #9
dwwCommitted #7 to Project HEAD, imported into bzr vendor, merged into drupal.org branch, and deployed:
http://drupal.org/node/3281/release
drumm's fixes for drupalorg_crossite are now live on redesign:
http://redesign.drupal.org/node/3281/release
Calling this done.