Download & Extend

Don't log IPs of registered voters

Project:Voting API
Version:6.x-2.3
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

The patch enables a votingapi relation and action for views and provides the possibility to turn off IP-logging for registered users.

The comment_moderation module is based on votingapi and written by Kyle Cunningham. He gave us a development version and we extended it. Now it works and provides a slashdot-like user based comment moderation. But it can also be used as a convenient moderation tool. We'll use it at our upcoming website linksunten.indymedia.org.

IMC linksunten

AttachmentSize
votingapi-nolog_regip.diff2.46 KB
09-01-15-comment_moderation.tar_.gz7.9 KB

Comments

#1

This version of comment_moderation should work together with comment_mover...
http://drupal.org/node/360095#comment-1205288

...and with hidden:
http://drupal.org/node/359074

AttachmentSize
09-01-17-comment_moderation.tar_.gz 7.87 KB

#2

Status:needs review» postponed

There's a problem with this approach, unfortunately: without the IP checking, anonymous voting wouldn't really be possible. Also, have you considered posting the comment moderation as a standalone module? VotingAPI itself doesn't implement any user-facing voting widgets; it's just about managing the data.

I'm going to be postponing this one until the 2.1 release; there are still some questions that need to be ironed out, IMO.

#3

Yes, you are right, that's why we made the IP checking optional. We don't want to store any IP adresses but if someone wishes to: it's still the default.

We are not going to release the comment moderation module since CitizenKane will. He started the project, we just enhanced his code and made it work.

#4

I'd love to see where this goes as this is exactly the kind of functionality I would like to see moving forward with comments and the voting api.

#5

Sorry we don't have time for this module at the moment. Attached is the current version we are using at http://linksunten.indymedia.org

You might want to have a look at http://lists.indymedia.org/pipermail/imc-drupal-dev/2009-March/0305-18.html and http://linksunten.indymedia.org/en/node/770

IMC linksunten

AttachmentSize
09-03-27-comment_moderation.tar_.gz 8.19 KB

#6

Thanks. I appreciate it.

#7

Title:No IP-logging and comment moderation module» Log IPs only for anonymous voters
Status:postponed» needs work

Seems to me this would be a good feature. The idea here is to avoid logging IPs when we don't *need* to. I think the patch doesn't quite do that: it's really a kill switch that *will* break anonymous user voting in its current state. Also, I don't quite understand the reason behind the first chunk of the patch.

I think that if the setting really applies to only anonymous users, there's no reason why it shouldn't get in.

#8

Version:6.x-2.0-rc2» 6.x-2.3

The first part is not necessary anymore. We are using the attached two patches with version 2.3 of VotingAPI. We really don't want to log IP addresses and I don't see any reason why we should not be allowed to turn the logging off.

AttachmentSize
votingapi-6.x-2.3.linksunten.admin_.inc_.diff 475 bytes
votingapi-6.x-2.3.linksunten.module.diff 330 bytes

#9

I missed the boat here but why is logging IP addresses a problem?

#10

Because it compromises anonymity. We do not want to log IP addresses so that our authors are protected in case of infiltration or in case of a server seizure.

#11

Ok, well then I would change the name of the variable. Its abbreviated nonsense now. maybe something like 'votingapi_obsecure_ip'. The default value for the variable should be FALSE not TRUE.

#12

Title:Log IPs only for anonymous voters» Don't log IPs of registered voters

Changed title