I seem to be getting 20 photos maximum in my flickr-photoset pages. It'd be nice to have a way to specify the number of images returned from this query.

CommentFileSizeAuthor
#8 arbitrary_number_of_images_for_D6-360157-8.patch7.56 KBlolandese
#7 arbitrary_number_of_images_for_D6-360157-7.patch9.31 KBlolandese
#6 arbitrary_number_of_images_for_D6-360157-6.patch8.72 KBlolandese
#3 arbitrary_number_of_images-360157-1.patch6.57 KBlolandese

Comments

Anonymous’s picture

Anonymous (not verified) commented

Sounds like a good idea, would anyone like to work on this ?

Anonymous’s picture

Anonymous (not verified) commented
Title: Ability to define the number of images in the photoset query. » [PRIORITY 4] Ability to define the number of images in the photoset query.
lolandese’s picture

lolandese commented
Title: [PRIORITY 4] Ability to define the number of images in the photoset query. » Ability to define an arbitrary number of images in the photoset and blocks
Version: 6.x-1.0-beta1 » 7.x-1.x-dev
Component: flickr_sets » flickr (main module)
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new arbitrary_number_of_images-360157-1.patch6.57 KB

Patch attached for D7. Accepts any number from 1 to 99 to be set for the blocks and 1 to 999 for the photosets. It offers finer control than the select dropdown field that is currently used.

Furthermore the number of code lines is reduced.

lolandese’s picture

lolandese commented
Status: Needs review » Fixed

Committed. See http://drupalcode.org/project/flickr.git/commitdiff/bfab048.

It includes also suggestions from Code Sniffer (drush dcs).

lolandese’s picture

lolandese commented
Status: Fixed » Patch (to be ported)

To port to D6.

lolandese’s picture

lolandese commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new arbitrary_number_of_images_for_D6-360157-6.patch8.72 KB

Patch for D6.

No validation on flickr blocks configuration field 'Show n photos', but without dramatic consequences. It seems to accept only numbers anyway.

lolandese’s picture

lolandese commented
StatusFileSize
new arbitrary_number_of_images_for_D6-360157-7.patch9.31 KB

Patch for D6 with validation of block configuration field 'Show n photos'.

lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new arbitrary_number_of_images_for_D6-360157-8.patch7.56 KB

D6 patch rerolled against latest dev.

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

Tested with flickr_sets, flickr_filter and flickr_blocks. Works as expected, including validation of both on the block config as the module settings form.

For flickr_filter it needs a site clear cache before the number of images in a set changes. This is normal behaviour.

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

D6 commit http://drupalcode.org/project/flickr.git/commitdiff/065ca66

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.