I've created *-rtl.css files for views, based on 2.2 CSS files.
They were tested only on my dev version of Tendu theme, so this code needs review.
Attached a zip file with the original folder hierarchy, original CSS files with /*LTR*/ comments on the relevant lines, *-rtl.css files and arrow-active-rtl.png image.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | views-admin-rtl.css_.txt | 3.97 KB | elcuco |
| #8 | views-rtl.css_.txt | 580 bytes | elcuco |
| #1 | views2-rtl.patch | 16.79 KB | elcuco |
| #1 | arrow-active-rtl.png | 230 bytes | elcuco |
| views-rtl.zip | 6.38 KB | tombigel |
Comments
Comment #1
elcuco commentedLets patch`ify this zip.
I also attach the reversed arrow as a separate png
Comment #2
yhager commentedLooks and works very good. Thanks!
Comment #3
z.stolar commentedTested and found no problems.
Comment #4
z.stolar commentedTheme information should probably be LTR, but views doesn't supply any classes or IDs for styling it.
Comment #5
tombigel commentedthere is an id "views-ui-edit-display-form", the question is if it is unique for this form or not.
Comment #6
elcuco commentedz.stolar,
I added your request as #396994: Theming information must be LTR even on RTL displays, but it will need a little more love as my patch breaks the theme information a little bit. Lets keep problems separated.
Dear views maintainer,
we do need you to apply this patch ASAP so we can address #396994: Theming information must be LTR even on RTL displays and incrementally fix the display bug I described there (but it should only be fixed after this patch is applied and released).
Comment #7
merlinofchaos commentedelcuco: Please be patient. DrupalCon was at the beginning of March, then I went on vacation, and I've been drowning in this stuff. I apologize but I am not able to react to this stuff very quickly most of the time. This queue creates roughly 30 new issues every day. Please imagine what that means when you give me little hurry up speeches.
Also, the patch does not apply when I use 'patch -p0' because you did not create this patch using cvs diff -up from CVS. Please provide a proper patch.
Comment #8
elcuco commentedLets try it again:
This time I am attaching only the *-rtl.css files, and I remind you that the reversed arrow is here: http://drupal.org/files/issues/arrow-active-rtl.png
When this is in the CVS, I will provide a few patches which will in turn:
* add "padding-right:0" to the LTR css when they are overridden in the RTL css
* add /* LTR */ comments
* fix minor problems in the RTL css
I will do this in a few stages, as this is hard to find, but I hope that in every iteration the display will be usable, and will improve a little every time.
Comment #9
elcuco commentedComment #10
elcuco commentedping.... anything new with this issue?
Comment #11
elcuco commentedping once more...
Comment #12
merlinofchaos commentedYou need to set it back to needs review. Nobody ever sees stuff in needs work.
Comment #13
merlinofchaos commentedSigh. I thought there was a patch here. I will not try to figure out what's different between existing files and randomly posted files.
I've already asked for a proper patch. You went backwards. If you're not capable of providing proper patches, please don't bother. I don't have the time or energy to try and decipher this stuff.
Comment #14
elcuco commentedThese are new files, I am not touching existing files (yet), that will come in another patch.
I am trying to make this a multi-step process since it's a huge one, I went back since I don't think it's possible to do this in a one big step (lack of time from both of us, I have see the issue list of this project). See comment #7, in which my patch broke due to CVS changes.
My strategy is:
1) include this new files (affect only RTL users)
2) patch the LTR files
3) fix http://drupal.org/node/381994
4) continue adding patches to fix minor things that get broken in the way
Comment #15
yhager commented@elcuco: you can include new files in a CVS patch. It's a bit nasty, but I believe it will make merlinofchaos' life much easier if it is just a patch to apply. See more details at http://drupal.org/patch/create (look for Changing CVS/Entries to add and remove files manually)
Comment #16
poiu commented@elcuco (or whoever): If you want the throbber (ajax waiting icon thingie) to look ok in IE you need to make sure the containing tag hasLayout, my views-rtl.css looks like:
tested on IE6-8, FF3.5 and Chrome. I only tested it on sortable tables, so it might have adverse effects on other parts of the UI. zoom: 1; will probably do the trick if you don't care about valid css.
Comment #17
esmerel commentedIf someone wants to take this up and actually work on it, great. I'm leaving it open for that reason.
Comment #18
merlinofchaos commentedThere's not much point into getting this into 6.x at this point, and 7.x has this.