Adding a task to port the submodule to Drupal 6, so we can track progress.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | project_usage.diff | 17.25 KB | drumm |
| #6 | project_usage.diff | 1.02 KB | drumm |
| #4 | project_usage.diff | 17.28 KB | drumm |
| #3 | project_362134.patch | 13.85 KB | drewish |
Comments
Comment #1
gábor hojtsyComment #2
dwwYup, thanks. ;)
p.s. You know you can set issue tags on issue creation, not just followup, right? The same "Tags" fieldset is there in both cases.
Comment #3
drewish commentedHere's a starting patch. Totally untested.
Comment #4
drummAdded a permission for the admin menu item. Tried to get testing working, which is going decently, but setUp() is not correct since {cache_update} does not get created.
Comment #5
drummThat setUp() is not required. I determined the {cache_update} exceptions were somehting weird with my local install. The actual tests do pass.
Comment #6
drummComment #7
drummAck.. too late. Here is the real patch.
Comment #8
dwwChad committed this last night. Setting back to active since this has never actually been run, so it needs a little testing before we call it "fixed".
Comment #9
hass commentedMenu strings should not be t'ified, but patch contains t'ified menu strings.
Comment #10
drewish commentedHaas, assuming you mean should not be t()-ified...
Comment #11
gábor hojtsyHe is right, title and description is automatically t()-ified.
Comment #12
drewish commentedgabor, i agree that he's right but his comment appears to have a typo; there should not be t() calls in hook_menu()... but that said it looks like someone corrected it in the committed version.
Comment #13
dwwt() was already removed from project_usage_menu() in HEAD.
hunmonk committed yet more changes. This still needs real testing.
@hass: If you find anything else wrong, please submit patches. We're incredibly busy here at the d.o D6 upgrade sprint.
Comment #14
dwwFinally had a chance to test this on the d6 site, found/fixed/committed a few bugs, and deployed the working code on the site. Marking this fixed. Any remaining problems (which aren't already known-bugs) should go in new issues.