Adding a task to port the submodule to Drupal 6, so we can track progress.

Comments

gábor hojtsy’s picture

Issue tags: +drupal.org upgrade
dww’s picture

Yup, thanks. ;)

p.s. You know you can set issue tags on issue creation, not just followup, right? The same "Tags" fieldset is there in both cases.

drewish’s picture

Status: Active » Needs work
StatusFileSize
new13.85 KB

Here's a starting patch. Totally untested.

drumm’s picture

StatusFileSize
new17.28 KB

Added a permission for the admin menu item. Tried to get testing working, which is going decently, but setUp() is not correct since {cache_update} does not get created.

drumm’s picture

That setUp() is not required. I determined the {cache_update} exceptions were somehting weird with my local install. The actual tests do pass.

drumm’s picture

StatusFileSize
new1.02 KB
drumm’s picture

StatusFileSize
new17.25 KB

Ack.. too late. Here is the real patch.

dww’s picture

Status: Needs work » Active

Chad committed this last night. Setting back to active since this has never actually been run, so it needs a little testing before we call it "fixed".

hass’s picture

Menu strings should not be t'ified, but patch contains t'ified menu strings.

drewish’s picture

Haas, assuming you mean should not be t()-ified...

gábor hojtsy’s picture

He is right, title and description is automatically t()-ified.

drewish’s picture

gabor, i agree that he's right but his comment appears to have a typo; there should not be t() calls in hook_menu()... but that said it looks like someone corrected it in the committed version.

dww’s picture

t() was already removed from project_usage_menu() in HEAD.
hunmonk committed yet more changes. This still needs real testing.

@hass: If you find anything else wrong, please submit patches. We're incredibly busy here at the d.o D6 upgrade sprint.

dww’s picture

Status: Active » Fixed

Finally had a chance to test this on the d6 site, found/fixed/committed a few bugs, and deployed the working code on the site. Marking this fixed. Any remaining problems (which aren't already known-bugs) should go in new issues.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org upgrade

Automatically closed -- issue fixed for 2 weeks with no activity.