Hi,

I just tested this on two different Drupal 5 installations (5.2 and 5.10). Same problem.

When I try to add users to the electoral list on a new decision in a fresh install, nothing happens.

The selected user (the dropdown works) does not appear in the table.

I tried toggling the "Use electoral list by default:" setting. Don't know what else to do.

Thanks!

dru

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

There are two form functions that are not named correctly.
The form id for submitting new electors is "decisions_electoral_list_form", so drupal is expecting to find two functions, decisions_electoral_list_form_validate() and decisions_electoral_list_form_submit().

Fix:

  1. open decisions.module
  2. Find line 925:
    function decisions_electoral_list_validate($form_id, $form_values) {
  3. Change to:
    function decisions_electoral_list_form_validate($form_id, $form_values) {
  4. find line 947:
    function decisions_electoral_list_submit($form_id, $form_values) {
  5. Change to:
    function decisions_electoral_list_form_submit($form_id, $form_values) {

There is also a duplicate of the form code that can be removed. Lines 845 to and including 872 can be removed entirely since the actual form is delivered through the function call on line 873.

Sorry about not providing a proper patch file, but I didn't have the time and tools at the moment.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

Fix committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.