Download & Extend
Simplenews » Issues

!confirmation_url / !newsletter variables not expanded in confirmation email.

Posted by durruti on January 28, 2009 at 2:00pm
Project:Simplenews
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In my confirmation email the !mail_to and !site variables are working properly, but the !newsletter and !confirmation_url are not. This is the case either using the subscription form within the newsletter block or following a link to the form. You can see the form at http://openspace.coop/latest. Any idea what I'm doing wrong?

We have received a request for subscription of me@myaddress.org  to the !newsletter on OpenSpace website at http://openspace.coop. To confirm this subscription please use the link below.

!confirmation_url

Many thanks,
Matt

Login or register to post comments

Comments

#1

Posted by Sutharsan on January 29, 2009 at 6:46pm
Status:active» fixed

With the latest release some of the variables have changed. See the description.

Available variables are: !site, !uri, !uri_brief, !mailto, !date, !newsletter_name, !confirm_subscribe_url, !confirm_unsubscribe_url.

#2

Posted by System Message on February 12, 2009 at 6:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#3

Posted by catofcheshir on April 28, 2009 at 6:51am

!site & !mailto doesn't work for anonymous subscribers, because this tokens get from user_mail_tokens() :(

#4

Posted by catofcheshir on April 28, 2009 at 6:52am
Category:support request» bug report
Status:closed (fixed)» active

#5

Posted by donquixote on April 28, 2009 at 10:16am

subscribe

#6

Posted by Cornald on May 10, 2009 at 1:24pm

subscribe

Same issue here using Drupal 6.11 and simplenews 6.x-1.0-rc6

#7

Posted by arnoldc on May 11, 2009 at 11:50pm

Same issue here, !mailto and !site are not working in RC6 for annoymous users.

#8

Posted by phd_hiren on May 12, 2009 at 9:16am

subscribing

#9

Posted by mcarrera on May 13, 2009 at 1:09pm

subscribe

#10

Posted by Roberto Gerola on May 27, 2009 at 3:00pm

In simplenews.module file, around line 2120, this code should fix the issue :

  // Get tokens from user_mail_tokens() and add simplenews variables.
  if($subscription->uid) {
    $vars = user_mail_tokens($subscription, $language);
  }
  else {
    $vars = array();
    $vars['!site'] = variable_get('site_name', 'Drupal');
    $vars['!mailto'] = $subscription->mail;
  }

If necessary, other variables can be found here :
http://api.drupal.org/api/function/user_mail_tokens

Roberto
--
http://speedtech.it

#11

Posted by vendeka on May 24, 2009 at 10:52am

subscribing

#12

Posted by BenKewell on May 25, 2009 at 7:39pm
Version:6.x-1.0-rc4» 6.x-1.x-dev

issue in #3 still occurs in rc6 and dev,
patch in #10 solves the problem

#13

Posted by ñull on June 4, 2009 at 6:03pm
Status:active» reviewed & tested by the community

The same patch as #10 but now attached in CVS patch file against HEAD. May be this helps the maintainer to include it?

AttachmentSizeStatusTest resultOperations
simplenews.module.anonymous.confirmation.mail_.tokens.patch1.22 KBIgnored: Check issue status.NoneNone

#14

Posted by pcorbett on June 25, 2009 at 12:49am
Version:6.x-1.x-dev» 6.x-1.0-rc6

Patch #13 worked for me.

#15

Posted by nadavoid on August 8, 2009 at 5:02pm

I too have tested this patch, and it works great. Seems like an absolute necessity to be added to the module. Hoping a maintainer can apply this patch soon and have it in rc7.

#16

Posted by Sutharsan on August 9, 2009 at 10:48am
Status:reviewed & tested by the community» fixed

Although I have not been able to reproduce the error I have committed the patch to HEAD and 6.x-1.x-dev. Thanks Roberto Gerola and com2.

#17

Posted by plebe on August 13, 2009 at 4:31pm

inserting manually the #13 code worked for me, couldn't get the patch to run properly. Probably just me not knowing how to apply patch.

#18

Posted by Sutharsan on August 13, 2009 at 7:16pm

No need to apply the patch, use the latest 6.x-1.x-dev release. Please report your test results.

#19

Posted by jdwfly on August 19, 2009 at 5:47pm

I am running an already patched up version of simplenews, so I tried out the patch but it failed. Probably because my simplenews.module is already patched a couple of times. Anyway, I put the lines in manually where they are supposed to be and it works just like it should. Thanks

#20

Posted by adam_b on August 21, 2009 at 7:30pm
Version:6.x-1.0-rc6» 6.x-1.x-dev
Status:fixed» needs work

I've upgraded to the dev edition, but although it's fixed !site, I'm still not seeing the values for !date and !login_uri.

I chucked in all the variables from the instructions below the Body field and the test email read:

[name] (the name of your website),
http://[domain]/ (a link to your homepage),
[domain]/ (homepage link without the http://),
!date (today's date),
!login_uri (link to login page),
http://[domain]/newsletter/confirm/add/f04e1b96c60t22
(subscription confirmation link),
http://[domain]/newsletter/confirm/remove/f04e1b96c60t22
(unsubscription link),
http://[domain]/node/187 (link to this newsletter issue),
[name] newsletter (name of this newsletter series)

#21

Posted by portulaca on September 5, 2009 at 7:58pm

I had problems with !mailto and !site in subscription confirmation email, and I can confirm the dev version fixes it.

#22

Posted by Danny_Joris on September 8, 2009 at 4:57pm

Same here as #21. The dev fixes this.

#23

Posted by Sutharsan on September 9, 2009 at 1:30pm
Status:needs work» fixed

Attached patch fixes adam_b's bug in #20. Patch applied to dev.

AttachmentSizeStatusTest resultOperations
simplenews.365507.patch880 bytesIgnored: Check issue status.NoneNone

#24

Posted by System Message on September 23, 2009 at 1:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.