Working on this now so we can kill the cvs_messages_cid row in {sequences} in the xcvs* scripts.
First step is porting all of cvs.install to schema API (thanks, deadwood!).

CommentFileSizeAuthor
#3 366389-3.xcvs_autoincrement.patch2.05 KBdww
#1 366389-1.cvs_messages.patch2.03 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 366389-1.cvs_messages.patch2.03 KB

Any objections?

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Forgot about this in the DB update:

  $ret[] = update_sql("DELETE FROM {sequences} WHERE name = 'cvs_messages_cid'");

Committed to HEAD.

dww’s picture

dww
we/he/they
commented
Category: task » bug
Priority: Normal » Critical
Status: Fixed » Needs review
Issue tags: +drupal.org upgrade
StatusFileSize
new 366389-3.xcvs_autoincrement.patch2.05 KB

Bah, this was totally wrong and completely broke the ability to commit changes to the testing CVS repo. See #367720: Can't commit changes to staging CVS repo. Attached patch solves it.

gerhard killesreiter’s picture

gerhard killesreiter commented

This looks ok, but I probably said the same about the previous patch...

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Committed and deployed, now working fine.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org upgrade

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +drupal.org upgrade

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.