Project download regressions

http://drupal.org/node/366959 was not applied to the main tree. Why are we maintaining patches, already?

A) Sorting is due to ApacheSolr as per Damien: #366959: Solr_Base_Query::solrsort is inconsistent -- I guess I'll have to roll out the patched apachesolr.module to the test site tomorrow.

B) I'll have to check with Damien about making a facet block like that appear anywhere else on the site -- normally those blocks only appear on search-specific pages. Should be doable, might just be a bit ugly under the hood. We'll see.

C) Critical: I can't filter downloads by Drupal version.: http://drupal.org/node/366562#comment-1230332

D) Critical: http://d6.drupal.org/project/drupal%20project shows stuff other than Drupal... 2 part problem:
- #273793: alias /download to /project/drupal
- The project_solr search pages should probably add an automatic filter on projects with releases (which is the current behavior of the project browsing pages). See attached patch to project_solr.module.

E) Screenshots in the themes -- yeah, we saw that on Friday when the test site went live, but haven't had a chance to look into it closely yet. Either weirdness with the D6 port of image_attach, or the D6 bluebeach port.

So, attached patch for part of (D). @Damien: any objections, or should I just commit this?

Removing title cruft.

starbow also played with this stuff and posted some suggestions at #368783: Faceted Search of modules needs work. Many are duplicate with what webchick reported here, but I'm just going to merge the two issues so we have a single place to go through all this. Here's what he wrote:

1. What order does http://d6.drupal.org/project/modules default to? The UI claims it is sorted by title, descending, but that is not true.
2. Sorting by title is confusing for lower case. It appears to be sorting A-Z then a-z. Case insensitive sorting would be more humane. This is particularly confusing for the jQuery related modules.
3. Sorting by author is confusing, since the authors name is not part of the teaser. Also, it puts the modules owned by Anonymous first on the list (which is weird, because then comes aaron, who comes before Ainur, so capitalization is not treated the same as it is for project name).
4. And sorting by date is also confusing, because it is not clear what date is being used. The project teaser shows many dates (one for each supported version), but those dates are not what is being sorted by. It believe it is being sorted by the invisible date of the last CVS checkin.
5. If I submit a search tearm, and then click one of the sort options to change the sort order, my search term is lost!!!

Suggestions
a. Get the title to reflect what facets are being sorted by instead of just showing "Modules".
b. Get the results count into the title, or somewhere obvious.
c. It really needs a Drupal version facet (I am sure you know this :)
d. Swap the position of the search and sort boxes. Search is much more important and useful.

Late Friday night I finished, committed, and deployed some changes to address a lot of this. I've crossed out the stuff from webchick's original post and starbow's comments (pasted into #5) that are now taken care of:

Problems:

1) The default sort is working and marked in the sort block

3) Agreed, that's a silly thing to ever want to sort on. We just removed that entirely (although the author is now listed on the search results).

4) Should be better now since the dates you can sort by are more clearly labeled, and those dates are also displayed directly in the search result teasers (moving us closer to http://infrastructure.drupal.org/drupal.org-style-guide/prototype/module... in appearance)

Suggestions:

c) Done. Yes, we knew: http://drupal.org/node/366562#comment-1230332 ;)

d) Done.

Setting this back to active for the remaining problems in here.

This is all project_solr code at this point, moving to a more appropriate queue...

Courtesy of the drupal.org sprint.

5. If I submit a search tearm, and then click one of the sort options to change the sort order, my search term is lost!!!

Done. http://drupal.org/cvs?commit=170236

Closed for now (there are no more regressions).

@Damien: I spent a whole morning working a/ pwolanin removing these project-specific hacks and duplicated code from ApacheSolr. I have no time to look closely now, but the readdition of a ProjectSolrQuery file leads me to believe this commit was a regression. ;)

And, there are still valid points in this thread that aren't addressed. So please don't mark fixed. You can reomove the d.o upgrade tag if it all works, but I don't want to lose the other items.

Crossing out things that are now done

Note: someone submitted #378858: Display module search box on individual module pages as well as a duplicate of this, but it doesn't hurt to have that in its own issue, anyway, so let's move that part of this discussion there.

whoops, dunno why that tag got removed with my reply

Based on #8, I'm changing the component to ApacheSolr integration. Please change back if that's not correct.

adding link to #378858 for part of this

It seems everything is fixed or irrelevant here.