tableheader.js produces an error in pages linked with #fragments, as reported at http://drupal.org/node/184143, comment #21. The fix reported there by gunzip works fine for me, so I am attaching a patch here, as requested by redndahead.

CommentFileSizeAuthor
#1 core-367088-1.patch1022 bytesegfrith
tableheader.js_.patch874 bytesgustav

Comments

egfrith’s picture

egfrith commented
StatusFileSize
new core-367088-1.patch1022 bytes

The patch fixes this issue for me. However, I noticed that the coding standards for JS files were broken by no space between the if and the ( and no space between the 'td' and +. (This also occurred in the original code.) New, cleaner, patch attached.

egfrith’s picture

egfrith commented

P.S. I had difficulty finding this issue, so here are a few keywords about it:

To reproduce in Firefox, create a story (or forum post) and attach a file to it. Then try posting a comment. The javascript elements in the page don't work, and an error message appers in the javascript console:

$("td" + location.hash).offset() has no properties
http://www.example.com/misc/tableheader.jk?K Line:73
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Closed (duplicate)

This is duplicate of #325810: Issue when using dimensions jquery plugin in tableheader.js.