Closed (fixed)
Project:
CVS integration
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Jan 2009 at 16:35 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwI can reproduce this. He's talking about the subtabs under the "Edit" tab on user account pages. The "Edit" tab itself disappears for the CVS and My newsletter subtabs, too, even though the path for those is still, e.g. http://d6.drupal.org/user/46549/edit/cvs -- weird. Some odd D6 menu mojo at work here, if someone wants to investigate.
Comment #2
gábor hojtsySeen this bug while testing, but did not find a way to fix. Tried to sync up the menu placeholders to use the same as in user module, but it did not seem to work. Tips welcome!
Comment #3
fagoI ran into the same problem with content profile, it's weird. The problem is that %user_category checks for the existence of the category or it returns false. So you need to have the category in place..
For content profile I saved it that way I returned the tabs as categories through hook_user() and then hijacked the menu items by hook_menu_alter().
More details at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/content_pro... ;)
Comment #4
gábor hojtsyThis sounds like a core bug then which you try to work around with a hack, but should instead be fixed in core. Another good way the drupal.org redesign could help improve Drupal itself :)
Comment #5
damien tournoud commentedThis might be related to #259679: user/[uid]/edit tab not present at user's visits tracker.
Comment #6
fagoYep, it's related. I've also noted this.
I remember that when I developed the workaround for cp, I noticed that another placeholder than %user_category wasn't working right - as the check for an available category fails. %user_category assumes that every at user/%/edit/$current_arg has to be a category - which is a wrong assumption. I don't see why there is this check needed anyway as there is menu item for every category.
Comment #7
gábor hojtsyVery similar to #367069: Where did "My tracker" go?
Comment #8
gábor hojtsyIn fact, the problem is that the user module tries to verify us as as category, so if we don't have a category, it does not work out with the parent tabs, so they disappear. So we need a category to let the parent tabs appear. What Peter supported is either migrate the full forms code to the user hook with submission and all, but it adds a lot of cruft (eg. a delete button on its own - which would be highly confusing for us). The other thing Peter suggested is to expose this category and then alter the user module created menu items, so we can override the menu item. That is what I did, tested and it works out fine.
Committing this to lists.module.
Comment #9
gábor hojtsyComment #10
gábor hojtsyHere is a patch for the same issue in cvslog module. Same solution. Contrary to the code comment, we can move that stuff to hook_user() since we can then alter the menu and use our own page callback and access callback. And this fixes the default tab issue which was in the comment, so it gets even better for non-drupal.org users even. It does fix the Edit tab not showing up and all sibling tabs not showing up issue as well of course.
Committing this for instant testing on d6.drupal.org and we can work on that more if it still have issues. The core issue at #259679: user/[uid]/edit tab not present at user's visits tracker might affect how we fix that, but for the contrib fix, these worked for cvslog and lists module.
Comment #11
gábor hojtsyThis was the file, but it did not appear.