Closed (fixed)
Project:
Thickbox
Version:
6.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
2 Feb 2009 at 18:39 UTC
Updated:
25 Mar 2009 at 22:10 UTC
Jump to comment: Most recent file
translation for the text "close or Esc Key"
not working on the popup login box
only the original English version is shown
but working for thickbox elsewhere
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | thickbox.patch | 1 KB | jankoch |
Comments
Comment #1
jankoch commentedBug in thickbox.js (line 234). The author forgot to subsitute the text in the ajax modal part with the values from Drupal.settings.thickbox, so static text was used.
Bug was originally identified in version 6.x-1.1, upgrading to current version (6.x-1.2) didn't help since the bug was still in it.
I created a patch to fix this particular problem: The modal ajax type should now handle localizations as any other type.
Comment #2
benkewell commentedwow! thanks a lot~ =)
has this been committed in the latest dev branch?
Comment #3
jankoch commentedI don't know, I am new to this forum/ticketing platform. I thought marking the status to fixed or patch (needs review) would suffice for the core developers of certain modules to take the code into cvs. To be frank, I haven't read a lot in the Issue queue handbook. I just started my first drupal project an ran into some things that didn't work for me and I couldn't find a fix for, so I fixed them. Since for two of those issues I found Requests here on drupal.org I thought I should post some patches. Perhaps you could help getting the stuff into the dev branch or letting me know how to do it!
Btw, since you use thickbox, you might be interested in this as well:
http://drupal.org/node/152712#comment-1337860
Best,
Jan
Comment #4
frjo commentedThanks for the patch jankoch, committed to 6-dev.