setting the digest newsletter settings

Could be a bug in d6 upgrade. I'll look into it when I get a chance.

I'll let you know if it actually sends (cron is set to run in a couple hours from now)

It didn't send anything.

I have one newsletter with three allowed content types and some new content from each content type added and tagged with that specific newsletter's taxonomy term.

The digest settings are set to send it out daily at 1700h and my cron is set to 17:10 and it did run successfully.

I'm wondering if it does have anything to do with the error I originally posted...

The d6 version has not been tested at all (at least not by me). So there are likely problems with it and that's why it is in development status. I will try to troubleshoot this as soon as I am able but it could be a bit.

Thank you for taking the time and reporting this.

thx! I can't see me using SimpleNews without it...as without it, it just sends out the posts as they are created/edited right? that'd be annoying to users.

I never used it (SimpleNews) in d5

I'll be eagerly awaiting

Steve - any luck with testing in D6? I'm very eager to use this and I can't use SimpleNews til I get this digest working.

is it a bug or is it something I'm doing wrong (I wouldn't be surprised if it was the latter!)??

while debugging the module file , found that in simplenews_digest_form_alter function , the line that actually set the form handler:

$form_data['#submit'][] = 'simplenews_digest_settings_handler_submit';

should be:

$form['#submit'][] = 'simplenews_digest_settings_handler_submit';

that allows to actually save the time settings and shows the right status message. now i am trying to debug the cron injection. i'll post back any progress

I'd be happy to test something if you have an update to try. I'm dying to get this going.

RodrigoNP's suggested code change (made to /modules/simplenews_digest/simplenews_digest.module) makes it possible to save digest settings. I'm not sure if this actually enables digest newsletters to be sent, but I will post back when I find out.

I made the code change as well and the 'Status Report' info in the Digest settings (/admin/settings/simplenews/digest_settings) is now showing something...but I wonder where it's getting its info from - it reads:

Newer nodes created between Feb 3, 2009 04:07:36 pm and Feb 4, 2009 01:59:59 pm will be sent out on a cron run per the settings below.

I have it set to send daily digests (just so I don't have to wait a week to test it) so I'm guessing it's looking at the date this module was installed on? (just a guess).

If so, how can I reset and get it to catch up on existing content? or I'd be happy if it'd just pick up the latest content.

if I change it to send out weekly, the status report info shows the week starting Feb 4th and if I set it to monthly, it changes to Feb 4th to March 1

I created new posts and dated them to fall inbetween the above dates. I let cron lapse and nothing was sent. I ran cron manually...and nothing was sent. In the 'Sent newsletter' page, it still shows those posts as not being sent.

the date in the status report has now moved ahead one day. I think I'm going to change the settings to week and keep running cron manually to at least get the date caught up.

any suggestions? I feel we're making progress....just nothing is being sent...

how do I adjust settings to include posts in the digest???

Upon node creation, if I choose "Send now" it sends the post individually immediately and the post shows as being sent in the 'Sent Newsletters' page.

If I choose not to send it, it doesn't get sent of course but it then doesn't show up in the 'Sent Newsletters' page (as being queued to be sent at cron)

#mdowset: The Digest is just that. It should automatically send out digest news with all the latest content from you your site (whatever you configure). So you cannot force it other than let Cron handle the dispatch. Only thing you can do to test is set Digest to send out every 1 day, set it to the neares whole hour, make sure you have new content, and set cron to run every 10 min. or so.

Check your Reports/Recent logs... You may filter for Cron and Simplenews. This way you only see pertinent info in the log.

This should dispatch a digest per your configuration. I have done this and nothing gets sent out from Digest.

Peculiar. After I changed the above code - Digest is now looking at the right time-window. Still nothing goes out from Digest.

#RodrigoNP: Did you get a chance to find the error with Digest? We're all dying to learn more. Thanks for the tip with the above bug.

Have a nice day.

Morten

hi all
you need to add this function to your module to implement hook_theme (new on drupal 6)

function simplenews_digest_theme() {
return array(
'simplenews_digest_format_newsletter' => array(
'arguments' => array('newsletter' => NULL),
),
);
}

Ahem - and just where do we put this code?

Thanks a million.

Morten E

Looking very much forward to get Digest up and running on 6.10.

insert that function in the simplenews_digest.module

Subscribing.

I also am eagerly awaiting the Drupal 6 version of this module.

Hi, guys. Just wanted to say I'm sorry I can't help more with this. I can barely keep up with my paid work these days. But I am going to start upgrading my 5 sites to 6 in about a month or two and that will give me the incentive I need to update this module.

Thanks for your help with troubleshooting this.

Please? :-) If you update it now, It'll be ready when you need it. :-)

Subscribing.
If I could find out how to configure Eclipse or something similar to debug drupal, I may give it a try. Instructions on drupal.org for eclipse seem to refer to an older version of eclipse.

Subscribing.
If I could find out how to configure Eclipse or something similar to debug drupal, I would try to debug the module. Instructions on seem to refer to an older version of eclipse.

Subscribing.

so is #14 something that needs to be added to the code to make this module actually work in D6? If so, how do we get the module owner to do so?

I added #14 to the .module file but didn't make any difference.

Subscribing.

I just added both #7 and #14.

When I updated my settings, I received the message, 'Newer nodes created between Jan 8, 2009 09:07:45 pm and Jan 9, 2009 08:59:59 am will be sent out on a cron run per the settings below.'

Which is great, but today is the 27th of May, 2009... developments will be forthcoming. I just installed my server, maybe 8 days ago. So it could be my server settings.

*** Not the server settings.

I just checked, and my Cron job has caught everything up to today and there are newsletters in the queue waiting to send. It appears that everything is working as ordered.

I did the recommended changes in #7 and #14.

The Digest newsletters are being generated, but not sent. They are all automatically getting routed to the Drafts list.

See the line: if ($end_time && $current_time > $end_time)

Should that first occurrence of end_time be in there? ---Ashford

Thanks for the dialog and help. What line in the simplenews_digest.module should the code referenced in #14 be inserted? Sorry only know enough to open an editor.

Thanks

A function is a group of commands and/or values that makes a specific action happen. In this case, when Drupal changed versions, this function was needed and had never been added.

Open the simplenews_digest module in your HTML editor; insert the code to the bottom of your file; and save.

Coloryan, did you get your Digest newsletter to send? Mine is still being queued in Draft. My regular newsletters (group email messages) get sent.

Yes, mine are sending out properly. I can go through my settings again, but there was no real science behind it - it almost seems like I resubmitted the forms enough times that it started to work.

My only issue was on one site where the URLs were malformed and not including the root address before the /node/* information. I just gutted that site and am upgrading it to 6.x over the weekend. So, I'll be submitting digest again and let you know how it works out.

So far it's working well. I'm using the scheduling options module and have 20-30 stories set to be published over the next two months. The digest is sent weekly and my test runs have worked so far.

I've got it set up on two sites, one on D5, the other on D6. Let me know if you'd like to look them over.

I believe this is the same issue as this: http://drupal.org/node/515228; this: http://drupal.org/node/526418; and maybe some others. I have made a number of corrections to the module and committed them. Avail in the latest dev snapshot when it gets made later today.

Edited: Sorry. my mistake.

Hi

I'm using the latest dev release (July 24) but my digests are just going to draft. They show in the Draft Issues list as published but not sent.

Under Simplenews Digest settings, it says "Nodes created before: Jul 31, 2009 11:59:59 pm have been sent."

So it seems we still have the drafts problem?

Thanks

Automatically closed -- issue fixed for 2 weeks with no activity.

I'm sorry to re-open this, but I keep seeing this problem, and I've bounced around a few issues where it's been said to be fixed, but the problem still seems to exist: Digests are saved as simplenews newsletter drafts, but not automatically sent.

In CVS it says this:
July 23, 2009

Commit #241846 by Morris Singer at 17:31
Simplenews Digest: /modules/simplenews_digest/simplenews_digest.module 1.1.4.3 @ DRUPAL-6--1

Fixes bug where new newsletters are only added to draft outbox. Now they are sent automatically.

But, using this commit, I still have the same problem.

1. Is this issue fixed?
2. If so, where is the patch?
3. If not, how do we fix it?

Thanks.

Simplenews 6.x-1.0-rc6
Simplenews Digest 6.x-1.x-dev (2009-Jul-23)

See http://drupal.org/node/598482.

I found another clue to why the message goes to Draft vs Pending and never gets sent. The message must have a minimum of 14 words.