Well, looks like the module is still not working correctly with 'node privacy byrole' module. The problem only occurs while mass editing an album using the 'album contents' link. All the access control settings vanish once the page is submitted. Then I have to go and individually set the permissions which is very tiresome. :(

PS: I had this as a comment and as the author had replied that it didn't belong to the issue being discussed, I'm opening a new issue. Hope this isn't fixed already!

CommentFileSizeAuthor
#3 node_privacy_byrole_prefix.patch3.18 KBvhmauery

Comments

vhmauery’s picture

we are still working on node_access stuff. But there is a possibility that node_privacy_byrole is not playing well with acidfree.... It does work fine with some other node_access modules.

vhmauery’s picture

When the album contents view generates its form, it passes a prefix to the nodeapi 'form pre' call. Some modules seem to honor this when generating form controls, others don't. Can you load up your album contents view and check the source. Or it is possible that it puts its form item in 'form post'. Hmmm.

Does the control show up at all? I suppose if it doesn't show up, I might have to call 'form post' and paste that into the form too.

vhmauery’s picture

StatusFileSize
new3.18 KB

Okay, it shows up and I think that is about as much as we can expect Acidfree to do.

I looked into the problem and it is caused by the fact that node_privacy_byrole never expects to be used with more than one node on the form. Some other node_access modules use a $prefix when drawing the nodeapi 'form pre' form items. I have attached a patch that makes node_privacy_byrole do the same thing. If you apply this patch to the node_privacy_byrole module, it will work correctly for you. You might even consider opening a bug against that module and submitting this patch.

And I am closing this bug since it is no longer an Acidfree problem.

vhmauery’s picture

Status: Active » Closed (fixed)
inspiredbylife’s picture

Ah, thanks for all your effort! I'll report a bug against node_privacy_byrole module and point them to the patch you have provided here. :)