Revote forgets about old value [#369809]

In function _fivestar_cast_vote selects only vote_id when selecting old vote

This patch add value into select so modules depended on voting can count properly for example userpoints gained on voting can use hook_votingapi_update($vote, $new_value) to recalculate points depending on new value and removing old poins

Comment	File	Size	Author
#7	369809_revote_value_d5.patch	1.47 KB	andypost
#6	369809_revote_value_d5.patch	1.47 KB	andypost
	revote_value_d6.patch	1.5 KB	andypost
	revote_value_d5.patch	1.5 KB	andypost

Comments

Comment #1

andypost

he/him

Russian

commented 5 February 2009 at 18:37

Category:

support

» feature

Patch against CVS

Comment #2

andypost

he/him

Russian

commented 25 September 2009 at 08:21

Version:

5.x-1.x-dev

» 6.x-1.x-dev

Any progress?

Comment #3

ezra-g commented 22 October 2009 at 19:51

Status:

Needs review

» Fixed

Thanks for this patch!

Looking at _fivestar_cast_vote(), these queries are no longer preset. Instead, Fivestar calls the votingapi, which does _votingapi_select(), which includes a select all, which seems like it addresses the original intention of this patch. For this reason, I'm marking this issue as fixed but please re-open if this doesn't address the same issue as your patch.